Skip to content

Bug: IPLD Explorer not loading #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
Frijol opened this issue Feb 25, 2019 · 5 comments · Fixed by #168
Closed

Bug: IPLD Explorer not loading #164

Frijol opened this issue Feb 25, 2019 · 5 comments · Fixed by #168
Labels
bug Something isn't working

Comments

@Frijol
Copy link
Contributor

Frijol commented Feb 25, 2019

Describe the bug
Endless load screen including in Incognito

Does this bug apply to a specific lesson or tutorial, or does it appear to be sitewide?
Linked from successful completion of Basics 1: https://ipfs.io/ipfs/QmYJETQ15RAnKXoJxqpXzcvQ2DuQA35UHwJBTjTPCSs9Ky/#/explore/zdpuApm55Qv2zRxb3KKjVUxhQSw2r4a7jeiDV7163yCQnfivy

Expected behavior
Not sure yet what IPLD Explorer is supposed to look like but probably something should load!

Screenshots
screen shot 2019-02-25 at 10 36 19 am

To reproduce
Complete https://proto.school/#/basics/01 exercise & click on the View in IPLD.. link

Desktop (please complete the following information):

  • OS: Mac OSX
  • Browser Chrome
  • Version whatsmybrowser.org/b/HGLEACT

Additional context
Add any other context about the problem here.
@Frijol Frijol added the bug Something isn't working label Feb 25, 2019
@terichadbourne
Copy link
Member

This is a duplicate of #125 but helps us know that the issue applies across multiple lessons. I believe the issue is actually with IPLD Explorer, not ProtoSchool but am awaiting a chance to talk further with @olizilla.

@olizilla
Copy link
Collaborator

olizilla commented Mar 5, 2019

From waht I can see, IPLD explor is loading, but cannot discover the content on the network. My guess is that we need to update the version of js-ipfs that is bundled with proto.school. will test it out and PR.

@mikeal
Copy link
Member

mikeal commented Mar 5, 2019

When his originally was reported we were having issues with the seed nodes, have those issues been resolved?

@olizilla
Copy link
Collaborator

olizilla commented Mar 5, 2019 •
edited
Loading

From what I can see right now, IPLD explorer is loading, but cannot discover the content on the network. My guess is that we need to update the version of js-ipfs that is bundled with proto.school. will test it out and PR.

Also we're linking to an old snapshot of ipld explorer, which should still work fine, but may as well be updated to point to https://explore.ipld.io

@terichadbourne
Copy link
Member

Thanks for looking into this @olizilla. Happy to accept a PR, but if you need my help or want to look at anything together, just let me know.

olizilla added a commit that referenced this issue Mar 5, 2019
@olizilla
fix: ensure ipfs browser bundle is used
884857f 
- alias the ipfs dependency to the pre-built bundle.
- update link to explore.ipld.io
- update ipfs to latest release

This ensures the browser friendly ipfs bundle is used. Before this
PR we were seeing a bunch of errors when IPFS tried to init, which
are caused by trying to get webpack to bundle the node build and
not substituting all the browser friendly deps correctly. Luckily,
this work is done for us in the ipfs dist build, so just use that.

fixes #164
fixes #125

License: MIT
Signed-off-by: Oli Evans <[email protected]>
@olizilla olizilla mentioned this issue Mar 5, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: ensure ipfs browser bundle is used ProtoSchool/protoschool.github.io
4 participants
@mikeal @olizilla @Frijol @terichadbourne