fix: ensure ipfs browser bundle is used #168
Conversation
- alias the ipfs dependency to the pre-built bundle. - update link to explore.ipld.io - update ipfs to latest release This ensures the browser friendly ipfs bundle is used. Before this PR we were seeing a bunch of errors when IPFS tried to init, which are caused by trying to get webpack to bundle the node build and not substituting all the browser friendly deps correctly. Luckily, this work is done for us in the ipfs dist build, so just use that. fixes #164 fixes #125 License: MIT Signed-off-by: Oli Evans <[email protected]>
|
Thank you so much, @olizilla! I'm testing on localhost. When I submit what I believe to be correct answers for some of the easier exercises, I'm getting this in the console:
The error is coming from this function:
I don't receive any success or error message from the validator or any clues shown to the user. Is it immediately obvious to @mikeal or @olizilla what the issue might be? Are you able to reproduce the issue? |
|
@terichadbourne Can you try running |
|
see also "vue-cli generated project emits errors together with js-ipfs": ipfs/js-ipfs#1875 |
|
@olizilla Based on our convo on the GUI/in-browser call the other day, is your inclination that we should accept this PR using your current webpack solution and put a note in the issue Alan mentioned (ipfs/js-ipfs#1875) so someone there can let us know when there's a better fix available? Or did it sound like there's something we should be changing immediately? |
|
Yep, I would merge this as it fixes the issue, and add a note to that issue. |
This ensures the browser friendly ipfs bundle is used. Before this
PR we were seeing a bunch of errors when IPFS tried to init, which
are caused by trying to get webpack to bundle the node build and
not substituting all the browser friendly deps correctly. Luckily,
this work is done for us in the ipfs dist build, so just use that.
fixes #164
fixes #125
License: MIT
Signed-off-by: Oli Evans [email protected]