[Content] Optimize Occult Crescent, introduce ContentSpecificActions
#772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nd organize the individual phantom jobs according to the CCP. This removes OC's previous `ShouldUsePhantomActions` method, and upgrades the `BestPhantomAction` method to a `TryGet` method. Firstly to prevent all of the Phantom logic from running twice when an OC action is desired, and secondly to streamline the code needed within each job. This also replaces the Phantom Jobs' `region`s with actual separate (`private`) methods for each Job, and organizes them all in the order in which they appear in the CCP file.
…ll such action methods into. This is being done so more code doesn't need added to every single job, for every type of content.
zbee
requested review from
Akechi-kun,
Kaeris-Tempest,
Kagekazu and
edewen
as code owners
zbee
added
Optimization
edewen
approved these changes
Aug 24, 2025
Contributor
edewen
left a comment
edewen
left a comment
There was a problem hiding this comment.
Built and tested a couple classes on dummy. new method works fine
Tartarga
added a commit
to Tartarga/WrathCombo
that referenced
this pull request
Aug 24, 2025
Merged
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ShouldUsePhantomActions(this caused Phantom logic to run twice when a Phantom action was desired)
BestPhantomActionto aTryGet-style method, with areffor the action ID to go out, and the return being aboolfor whether an action was found(without this
ShouldUsePhantomActionswas required, which caused all Phantom logic to run twice)regions into their own methods(may as well, it only makes it harder to search for it if not in the file)
(couldn't believe this wasn't already the case)
ContentSpecificActionsOccultCrescent.TryGetPhantomAction(), andouts the returned action ID, and has aboolfor if there is one that should be executedContentSpecificActions.TryGet()can be called a single time in all jobs, and Variant/Bozja/etc will not need added to every jobs' code.