Skip to content

Conversation

@zbee
Copy link
Member

@zbee zbee commented Aug 24, 2025

  • Build out an initial Item-Usage Framework
    • Can Support Phoenix Downs and Potions (Stat and eventually maybe Healing)
    • Works vaguely similar to Action Retargeting
      • Organized by Presets instead of replacedAction?
        • Record Presets from the Combo used
    • Only works on All.Item actions
  • Build out an Inventory Framework
    • Find Item IDs based on a set of parameters
      • Stat Potions
      • Phoenix Down
      • Health Potions
      • Mana Potions
    • Load user's inventory
      • Sorted so that it could be found by the same set of parameters by which the items were found
      • Ordered by the amount of actual stat that items give
    • Check Inventory for a specified Item ID
    • ItemReady()
  • Build out a Global: Phoenix Down Retargeting Feature for testing the Framework

Will come in another PR, probably:

  • Build out a Global: Auto-Selected Pot Feature (mostly for testing)
    (would choose the correct pot for the job, and allow choosing "highest tier in inventory" or "second highest tier in inventory"; mainly so you don't have to keep them up to date on your bar)
  • Build out Global: Auto-Use Phoenix Down (Retargeted) Feature
    via ContentSpecificActions, to add auto-rezzing to all jobs
    would need CDF options
  • Build out Pots in Openers functionality
  • Build out IsPotSuggestedInEncounter or something
    keeps tracks of party member deaths, player being weak/DD'd etc, to advise against potting dead runs / dead burst phases.
    jobs will use this Property when checking whether to pot before burst.

Unrelated things also done here:

  • Occult Crescent's Revive action now finally Retargets to the Raise Stack
  • Cleaned up UseActionDetour

@zbee zbee added New Feature This adds a new option or feature WIP This is currently a work-in-progress labels Aug 24, 2025
@semanticdiff-com
Copy link

semanticdiff-com bot commented Aug 24, 2025

Review changes with  SemanticDiff

Changed Files
File Status
  WrathCombo/Data/ActionWatching.cs  61% smaller
  WrathCombo/CustomCombo/Functions/Config.cs  34% smaller
  WrathCombo/WrathCombo.cs  24% smaller
  WrathCombo/Core/ActionReplacer.cs  22% smaller
  WrathCombo/Combos/PvE/ALL/ALL.cs  0% smaller
  WrathCombo/Core/ItemUsage.cs  0% smaller
  WrathCombo/Services/Inventory.cs  0% smaller
  WrathCombo/Services/Service.cs  0% smaller
  docs/CODEOWNERS Unsupported file format

zbee added 25 commits September 2, 2025 15:12
# Conflicts:
#	WrathCombo/Data/ActionWatching.cs
Contains only items we could care about.
@zbee zbee removed the WIP This is currently a work-in-progress label Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

New Feature This adds a new option or feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant