Methods 'mm-dd-yyyy' and 'dd-mm-yyyy' inappropriately refer to ISO 8601 #4579
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kept the same link (where the formats are described), but changed the link description as appropriate for each method's format as shown on that same page, - Addresses doc issue Raku#4576
Where are you seeing this discussion? The link is to https://en.wikipedia.org/wiki/ISO_8601, and I went looking, but couldn't find any such discussion. mm-dd-yyyy and dd-mm-yyyy aren't even mentioned as output formats, much less discussed. All I could find were one or two mentions (not discussions) as input formats, but these two methods are both accessors, not constructors. The wikipedia article only mentioned them as things to be converted to yyyy-mm-dd, so this doesn't provide any support for the idea that it's not misleading to mention ISO8601 in the context of these two (unlike yyyy-mm-dd). |
The link has been corrected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ISO 8601 details YYYY-MM-DD format, but the same link also discusses other Gregorian time formats. To correct the existing description, this PR keeps the same link (where the formats are described), but changes the link description as appropriate for each method's format as shown on that same page,