Skip to content

Conversation

@abpolym
Copy link
Member

@abpolym abpolym commented Nov 1, 2025

Should resolve #541

The Mixture node performs model comparison via scale factors, so its contribution to the Bethe Free Energy (BFE) is not well-defined.
To avoid runtime errors and make BFE computations robust, we now define a placeholder @average_energy method for Mixture that:

  • emits a clear warning,
  • returns 0.0 as a safe default.

This ensures that global BFE evaluation does not fail when mixtures are present, while still alerting users that the term is undefined conceptually.

@abpolym abpolym linked an issue Nov 1, 2025 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Nov 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.17%. Comparing base (8a0be85) to head (1127f62).
⚠️ Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #546   +/-   ##
=======================================
  Coverage   76.17%   76.17%           
=======================================
  Files         207      207           
  Lines        6149     6149           
=======================================
  Hits         4684     4684           
  Misses       1465     1465           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bvdmitri bvdmitri merged commit 04401f2 into main Nov 4, 2025
12 checks passed
@bvdmitri bvdmitri deleted the 541-missing-average-energy-for-mixture-node branch November 4, 2025 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Missing Average Energy for Mixture node

4 participants