Skip to content

541 missing average energy for mixture node #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bvdmitri merged 2 commits into from
Nov 4, 2025
Merged

541 missing average energy for mixture node #546

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3cd8567
#541 Define AverageEnergy for Mixture node, throwing a warning.
abpolym Nov 1, 2025
1127f62
make format
abpolym Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/nodes/predefined/mixture.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,3 +194,17 @@ function collect_latest_marginals(::RequireMarginalFunctionalDependencies, facto

return marginal_names, marginals_observable
end

# FreeEnergy related functions
@average_energy Mixture (q_out::Any, q_switch::Any, q_inputs::ManyOf{N, Any}) where {N} = begin
@warn """
AverageEnergy not defined for Mixture node.

The Mixture node performs model comparison using log-scale factors,
hence its contribution to the Bethe Free Energy (BFE) is not well-defined.

Returning 0.0 as a placeholder. If you need a proper energy term,
consider expanding the mixture explicitly or using Gate-style nodes.
"""
return 0.0
end
Loading