fix when no from option is given #66
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bendavies
force-pushed
the
fix-from-option
branch
2 times, most recently
from
4fd561b to
505d78a
Compare
Ocramius
requested changes
May 26, 2018
| @@ -148,7 +148,7 @@ public function execute(InputInterface $input, OutputInterface $output) : int | |||
| // @todo fix flaky assumption about the path of the source repo... | |||
| $sourceRepo = CheckedOutRepository::fromPath(getcwd()); | |||
|
|
|||
| $fromRevision = $input->hasOption('from') | |||
| $fromRevision = $input->getOption('from') !== null | |||
There was a problem hiding this comment.
This kind of change requires a test addition
There was a problem hiding this comment.
Yep sorry, didn't see the command was tested. Will add.
There was a problem hiding this comment.
test already exists, updated it.
bendavies
force-pushed
the
fix-from-option
branch
from
505d78a to
7b6e1ce
Compare
|
@bendavies I think #73 fixed this already (by using the correct API in |
|
Bah 😂 |
Ocramius
added a commit
that referenced
this pull request
May 28, 2018
…OR* is picked Previously, only the *MINOR* version was being compared, leading to previous major versions being considered in the lookup for the lowest available stable release.
Ocramius
added a commit
that referenced
this pull request
May 28, 2018
…itories The reasoning behind this is that `symfony/console` has a very squishy API, and that can lead to a lot of headaches in upgrades or implicit API changes. Having an E2E test will ensure that the implementation details of `symfony/console` are also considered, since the interfaces really just lie.
Ocramius
added a commit
that referenced
this pull request
May 28, 2018
Ocramius
added a commit
that referenced
this pull request
May 28, 2018
…se from empty `git tag` list
Ocramius
added a commit
that referenced
this pull request
May 28, 2018
… comparisons on no valid detected versions
Ocramius
added a commit
that referenced
this pull request
May 28, 2018
…d in the selected stable minor releases
Ocramius
added a commit
that referenced
this pull request
May 28, 2018
Ocramius
added a commit
that referenced
this pull request
Jun 4, 2018
Ocramius
added a commit
that referenced
this pull request
Jun 4, 2018
Ocramius
added a commit
that referenced
this pull request
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hasOption=>Returns true if an InputOption object exists by name.