Check that --from is actually provided
#73
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 27, 2018
Ocramius
changed the title
--from is actually provided
|
Hmm, no, this patch completely killed I'll probably have to revert it completely and apply #66 instead. |
|
Sound fair - but write some end-to-end tests |
|
Yeah, will need to add some with example repos created on the fly.
…On Sun, 27 May 2018, 19:53 Ciaran McNulty, ***@***.***> wrote:
Sound fair - but write some end-to-end tests
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#73 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAJakO6qRAPKrQwBIpUgQ-bG03yUz02-ks5t2ugzgaJpZM4UPR6e>
.
|
Ocramius
added a commit
that referenced
this pull request
May 28, 2018
…OR* is picked Previously, only the *MINOR* version was being compared, leading to previous major versions being considered in the lookup for the lowest available stable release.
Ocramius
added a commit
that referenced
this pull request
May 28, 2018
…itories The reasoning behind this is that `symfony/console` has a very squishy API, and that can lead to a lot of headaches in upgrades or implicit API changes. Having an E2E test will ensure that the implementation details of `symfony/console` are also considered, since the interfaces really just lie.
Ocramius
added a commit
that referenced
this pull request
May 28, 2018
Ocramius
added a commit
that referenced
this pull request
May 28, 2018
…se from empty `git tag` list
Ocramius
added a commit
that referenced
this pull request
May 28, 2018
… comparisons on no valid detected versions
Ocramius
added a commit
that referenced
this pull request
May 28, 2018
…d in the selected stable minor releases
Ocramius
added a commit
that referenced
this pull request
May 28, 2018
Ocramius
added a commit
that referenced
this pull request
Jun 4, 2018
Ocramius
added a commit
that referenced
this pull request
Jun 4, 2018
Ocramius
added a commit
that referenced
this pull request
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #72 - in my instance
hasOptionis returning true because its been replaced with its default value ofnull.I'm mildly surprised that this hasn't happened to anyone pre-release though - are you always specifying a revision? It's possible that this is a symfony version thing.
I stuck to the existing paradigm for the tests but there's a lot of stubbing going on - it might be clearer to use a concrete ArgvInput (which would also have avoided the issue of stubbing enshrining an incorrect understanding of the API)