Skip to content

Conversation

@Firestar99
Copy link
Member

@Firestar99 Firestar99 commented Jul 14, 2025

better reviewed commit by commit

@Firestar99 Firestar99 force-pushed the fix-main-ci branch 3 times, most recently from c98ba9f to f395041 Compare July 14, 2025 10:38
@Firestar99 Firestar99 marked this pull request as draft July 14, 2025 10:38
@Firestar99 Firestar99 marked this pull request as ready for review July 14, 2025 11:01
@Firestar99 Firestar99 changed the title Fix main ci fix main ci Jul 14, 2025
Copy link
Contributor

@LegNeato LegNeato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need the precompile job?

@Firestar99
Copy link
Member Author

Firestar99 commented Jul 15, 2025

The precompile job exists to have a precompiled vulkan sdk to speed up CI times... but we can just use the same vulkan-sdk-install action from rust-gpu to install it instead of building our own infra. It's broken anyway since it staticly points to Embark's repo still

@Firestar99 Firestar99 merged commit 95fbcb2 into main Jul 15, 2025
6 checks passed
@Firestar99 Firestar99 deleted the fix-main-ci branch July 15, 2025 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants