Skip to content

Fix seed type & feature importance column #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 26, 2025
Merged

Fix seed type & feature importance column #46

merged 7 commits into from
Feb 26, 2025

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented Feb 26, 2025

Thanks to @ehb64 for reporting these issues! 👋🏻

Issues

Change(s) made

  • Make sure seed from get_wildcards_tbl() is numeric for proper joining in the train_ml and find_feature_importance rules.
  • mikropml v1.6.0 introduced a breaking change: in the output of find_feature_importance the names column was changed to feat. The feat_df column name is changed accordingly here in the plot_feature_importance rule.

Checklist

(Strikethrough any points that are not applicable.)

  • Update the docs if there are any API changes (README.md, config/README.md, & quick-start.md).
  • Re-run the pipeline on an HPC and update the example report.
  • The checks succeed on your most recent commit. This is always required before the PR can be merged.

@kelly-sovacool kelly-sovacool merged commit e892e6c into main Feb 26, 2025
@kelly-sovacool kelly-sovacool deleted the iss-44 branch February 26, 2025 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Issue with "names" in plot_feature_importance.R Issue with wildcards$seeds as.double
1 participant