SS-1250 add explicit flag for develop logs in settings #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Adds an explicit DEVELOP_LOGS_ENABLED flag to the studio settings ConfigMap to control logging behavior in development.
- Introduces
DEVELOP_LOGS_ENABLEDalongsideDEBUGin the ConfigMap - Switches various logging, Celery, and middleware conditionals from
DEBUGtoDEVELOP_LOGS_ENABLED
Comments suppressed due to low confidence (3)
serve/templates/studio-settings-configmap.yaml:49
- The
DEVELOP_LOGS_ENABLEDflag is still tied to.Values.studio.debug, so it isn’t truly explicit. Reference a new Helm value (e.g..Values.studio.developLogsEnabled) here so users can control it independently ofDEBUG.
DEVELOP_LOGS_ENABLED = True
serve/templates/studio-settings-configmap.yaml:150
- [nitpick] Indentation for this middleware entry should align with the other
INSTALLED_APPSlist items to keep the YAML readable and consistent.
+ (STRUCTLOG_MIDDLEWARE if not DEVELOP_LOGS_ENABLED else [])
serve/templates/studio-settings-configmap.yaml:49
- Consider adding unit or integration tests to verify that
DEVELOP_LOGS_ENABLEDtoggles logging, Celery, and middleware inclusion as expected in both true and false scenarios.
DEVELOP_LOGS_ENABLED = True
8 tasks
hamzaimran08
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful in development environment