Skip to content

SS-1250 add explicit flag for develop logs in settings #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
churnikov merged 1 commit into from
Jul 10, 2025
Merged

SS-1250 add explicit flag for develop logs in settings #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions serve/templates/studio-settings-configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,10 @@ data:
# SECURITY WARNING: don't run with debug turned on in production
{{ if .Values.studio.debug }}
DEBUG = True
DEVELOP_LOGS_ENABLED = True
{{ else }}
DEBUG = False
DEVELOP_LOGS_ENABLED = False
{{ end }}

if DEBUG:
Expand Down Expand Up @@ -87,7 +89,7 @@ data:
STRUCTLOG_MIDDLEWARE = [
"django_structlog.middlewares.RequestMiddleware"
]
DJANGO_STRUCTLOG_CELERY_ENABLED = not DEBUG
DJANGO_STRUCTLOG_CELERY_ENABLED = not DEVELOP_LOGS_ENABLED

# Application definition

Expand Down Expand Up @@ -145,7 +147,7 @@ data:
"waffle.middleware.WaffleMiddleware"
]
+ DJANGO_WIKI_MIDDLEWARE
+ (STRUCTLOG_MIDDLEWARE if not DEBUG else [])
+ (STRUCTLOG_MIDDLEWARE if not DEVELOP_LOGS_ENABLED else [])
)


Expand Down Expand Up @@ -540,11 +542,11 @@ data:
},
"loggers": {
"": {
"handlers": ["console" if DEBUG else "json"],
"level": "DEBUG" if DEBUG else "INFO",
"handlers": ["console" if DEVELOP_LOGS_ENABLED else "json"],
"level": "DEBUG" if DEVELOP_LOGS_ENABLED else "INFO",
},
"django.server": {
"handlers": ["console" if DEBUG else "json"],
"handlers": ["console" if DEVELOP_LOGS_ENABLED else "json"],
"level": "WARNING",
"propagate": False,
},
Expand All @@ -553,7 +555,7 @@ data:

LOGGING = add_loggers(LOGGING, INSTALLED_APPS)

if not DEBUG:
if not DEVELOP_LOGS_ENABLED:
structlog.configure(
processors=[
structlog.contextvars.merge_contextvars,
Expand Down