Skip to content

Conversation

@j-awada
Copy link
Contributor

@j-awada j-awada commented Mar 26, 2025

Description

Jira: https://scilifelab.atlassian.net/browse/SS-1401

E2E tests pass locally and fail on the GitHub workflow due to GHCR image validation issues. We suspect that the token is not set as an environment variable when the E2E tests run on GitHub.

Introduce code changes such that if the token is missing, do not validate the GHCR image.

Checklist

If you're unsure about any of the items below, don't hesitate to ask. We're here to help!
This is simply a reminder of what we are going to look for before merging your code.

  • This pull request is against develop branch (not applicable for hotfixes)
  • I have included a link to the issue on GitHub or JIRA (if any)
  • I have included migration files (if there are changes to the model classes)
  • I have included, reviewed and executed tests (unit and end2end) to complement my changes
  • I have updated the related documentation (if necessary)
  • I have added a reviewer for this pull request
  • I have added myself as an author for this pull request
  • In the case I have modified settings.py, then I have also updated the studio-settings-configmap.yaml file in serve-charts

@j-awada j-awada added the bug Something isn't working label Mar 26, 2025
@j-awada j-awada requested a review from alfredeen March 26, 2025 15:24
@j-awada j-awada self-assigned this Mar 26, 2025
@j-awada j-awada requested a review from a team as a code owner March 26, 2025 15:24
Copy link
Member

@alfredeen alfredeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@j-awada j-awada merged commit f4867b4 into develop Mar 27, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants