Skip to content

SS-1401 Address missing Github api token #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
j-awada merged 3 commits into from
Mar 27, 2025
Merged

SS-1401 Address missing Github api token #311

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
41d4eee
address missing github api token
j-awada Mar 26, 2025
df85e19
reinstate expected behaviour when the gh api token is missing
j-awada Mar 27, 2025
6c64578
increase wait time
j-awada Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .env.template
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ [email protected]
DEBUG=true
INIT=true

GITHUB_API_TOKEN=replace-me
GITHUB_API_TOKEN=

# This is an environment variable that deletes all data in database on start up of the app.
# Its primary use is for deployment on remote development environment.
Expand Down
4 changes: 4 additions & 0 deletions apps/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,10 @@ def validate_ghcr_image(image: str):
else:
raise ValidationError("Could not recognise the GHCR owner. Please try again.")

# Return the image if the GitHub API token is missing
if settings.GITHUB_API_TOKEN in ["", None]:
return image

headers = {"Authorization": f"Bearer {settings.GITHUB_API_TOKEN}", "Accept": "application/vnd.github+json"}

try:
Expand Down
Loading