Java. Event firing: improvements and new features #1034
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TikhomirovSergey
force-pushed
the
event-firing-java
branch
from
7eeacfd to
450477c
Compare
ddavison
added
Z-awaiting review
| @@ -170,9 +216,9 @@ public String getTitle() { | |||
| } | |||
|
|
|||
| public List<WebElement> findElements(By by) { | |||
| dispatcher.beforeFindBy(by, null, driver); | |||
| castDispatcher(SearchingEventListener.class).beforeFindBy(by, null, driver); | |||
There was a problem hiding this comment.
There are some spacing issues.
TikhomirovSergey
force-pushed
the
event-firing-java
branch
from
2581194 to
67df50e
Compare
|
@bootstraponline format issues were fixed |
TikhomirovSergey
force-pushed
the
event-firing-java
branch
2 times, most recently
from
2e91d4b to
efc9a26
Compare
|
👍 |
TikhomirovSergey
force-pushed
the
event-firing-java
branch
from
efc9a26 to
24eec0b
Compare
TikhomirovSergey
force-pushed
the
event-firing-java
branch
from
24eec0b to
84f264a
Compare
Problems - Current design doesn't allow end user to log events optionally. E.g. if they want to log only searchings or searchings and navigation then they are forced to leave unimplemented methods in their code - Current design doesn't allow to make any extension without backward compatibility problems because each new method should be implemented or left empty - There are some issue with the logging of thrown exceptions What has been done - WebDriverEvent listener was separated to few interfaces. It is still here and aggretes them (in order to support backward compatibility) - New listeners were added - EventFiringWebdraver was redesigned. The ability to use listeners optionally is provided now Warning!!! There is an issue of backward compatility. Users will face it if they directly use such classes as EventFiringKeyboard, EventFiringMouse, EventFiringTouch. But I hope there not many cases and it is not the critical issue.
3 tasks
|
Any interest on move this forward? |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problems
if they want to log only searchings or searchings and navigation then
they are forced to leave unimplemented methods in their code
compatibility problems because each new method should be implemented or
left empty
What has been done
here and aggretes them (in order to support backward compatibility)
optionally is provided now
Warning!!! There is an issue of backward compatility. Users will face it
if they directly use such classes as EventFiringKeyboard,
EventFiringMouse, EventFiringTouch. But I hope there not many cases and
it is not the critical issue.
This change is