EventFiringWebDriver: added an event on "submit()" #1179
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When "recording" the interaction with a page, there's the need to record the "submit" action. For us, this is similar to a "click()", so then we decided to dispatch the "click" event, but maybe a new "submit" event could be dispatched...
| @@ -349,7 +349,9 @@ public void click() { | |||
| } | |||
|
|
|||
| public void submit() { | |||
| dispatcher.beforeClickOn(element, driver); | |||
There was a problem hiding this comment.
this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener.
Since submit does not synthesize the 'click' events, this isn't accurate.
|
Guys |
|
Anyone still interested in this? I would like to use this feature and I can also take care of necessary changes to this PR (new rebase, interface changes, more tests, etc.). |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When "recording" the interaction with a page,
there's the need to record the "submit" action.
For us, this is similar to a "click()",
so then we decided to dispatch the "click" event,
but maybe a new "submit" event could be dispatched...
This change is