Skip to content

EventFiringWebDriver: added an event on "submit()" #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

EventFiringWebDriver: added an event on "submit()" #1179

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed4a527
EventFiringWebDriver: added an event on "submit()"
s2oBCN Oct 21, 2015
97caaaa
Merge branch 'master' into eventOnSubmit
s2oBCN Nov 25, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions java/client/src/org/openqa/selenium/support/events/EventFiringWebDriver.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,9 @@ public void click() {

@Override
public void submit() {
dispatcher.beforeClickOn(element, driver);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this shouldn't be beforeClickOn, but rather beforeSubmit? and added to WebDriverEventListener.

Since submit does not synthesize the 'click' events, this isn't accurate.

element.submit();
dispatcher.afterClickOn(element, driver);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

}

@Override
Expand Down
34 changes: 34 additions & 0 deletions java/client/test/org/openqa/selenium/support/events/EventFiringWebDriverTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,6 +169,40 @@ public void windowEvent() {
verifyNoMoreInteractions(mockedTargetLocator, listener);
}

@Test
public void submitEvent() {
final WebDriver mockedDriver = mock(WebDriver.class);
final WebElement mockedElement = mock(WebElement.class);
final StringBuilder log = new StringBuilder();

when(mockedDriver.findElement(By.name("foo"))).thenReturn(mockedElement);

EventFiringWebDriver testedDriver =
new EventFiringWebDriver(mockedDriver).register(new AbstractWebDriverEventListener() {
@Override
public void beforeClickOn(WebElement element, WebDriver driver) {
log.append("beforeClickOn\n");
}

@Override
public void afterClickOn(WebElement element, WebDriver driver) {
log.append("afterClickOn\n");
}
});

testedDriver.findElement(By.name("foo")).submit();

assertEquals(
"beforeClickOn\n" +
"afterClickOn\n",
log.toString());

InOrder order = Mockito.inOrder(mockedDriver, mockedElement);
order.verify(mockedDriver).findElement(By.name("foo"));
order.verify(mockedElement).submit();
order.verifyNoMoreInteractions();
}

@Test
public void changeValueEvent() {
final WebDriver mockedDriver = mock(WebDriver.class);
Expand Down