Skip to content

[Klaud Cold] minimaxm31flash-fp4-gb200-vllm-agentic-dspark: day-zero MiniMax-M3.1-Flash GB200 recipe matching B200 - #4433

Merged
Oseltamivir merged 3 commits into
mainfrom
feat/minimaxm31flash-gb200-dspark-b200parity
Oct 23, 2026
Merged

Oseltamivir merged 3 commits into
mainfrom
feat/minimaxm31flash-gb200-dspark-b200parity

Conversation

@Oseltamivir

Copy link
Copy Markdown
Collaborator

Summary

Day-zero MiniMax-M3.1-Flash AgentX on GB200 with vLLM and DSpark. The recipe and search space match the merged B200 recipe (#4426). This replaces #4424.

  • Config key: minimaxm31flash-fp4-gb200-vllm-agentic-dspark.
  • Recipe: a copy of minimaxm31flash/vllm/b200-fp4-mtp/agentic.yaml. Only gpu_type (gb200) and gpus_per_node (4) differ.
  • Image: vllm/vllm-openai:minimax-m31-flash-arm64-cu134@sha256:5d76347…, the arm64 build of B200's image (manifest sha256:86f582da…). It already ran cleanly on GB200 in [Klaud Cold] minimaxm31flash-fp4-gb200-vllm-agentic-dspark: day-zero MiniMax-M3.1-Flash GB200 DSpark recipe #4424.
  • Search space, the same as B200:
    • TP4 at conc 1/4/8/16/32 with 7-token DSpark (golden AL 4.04).
    • DEP4 (TP1 × DP4 + EP4, vLLM Router) at conc 64/128 with 3-token DSpark (golden AL 2.88).
    • Both use the FLASH_ATTN drafter.

Why this replaces #4424

#4424 used 3 draft tokens at TP4 (AL 2.88), and the B200 recipe uses 7 (AL 4.04). On GB200 the time per decode step was slightly lower than on B200: about 6.6 ms against 7.6 ms (TPOT × AL). But each step produced about 29% fewer tokens, so GB200 trailed B200 by 18–28% on TP4 interactivity. On DEP4, where both used 3 tokens, GB200 beat B200 by about 20% (c64) and about 10% (c128) on tokens/s/GPU.

#4424's TP4 c64 point was badly overloaded (median TTFT 131 s) and DEP4 c64 beat it on every metric, so it is dropped. DEP4 c256 is dropped to match B200.

Validation

infx generate binds all 7 points to exactly one variant each, with the expected speculative config and golden AL.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

  • Review: If this PR changes files owned by someone other than a repository admin or @SemiAnalysisAI/core, ask one eligible CODEOWNER to complete the latest PR_REVIEW_CHECKLIST.md before contacting a core maintainer on Slack. Follow the template exactly, including As a PR reviewer and CODEOWNER, I have reviewed this and have, so sign-off verification triggers.
  • PR verification: Sweeps run only when the PR appends an inferencex-e2e/perf-changelog.yaml entry and carries exactly one primary label: full-sweep-fail-fast (strongly recommended; canary plus per-matrix fail-fast), full-sweep-enabled (canary; matrix jobs continue after a failure), or non-canary-full-sweep-enabled (no canary or fail-fast). The modifiers all-evals, evals-only, and agentx-fast require a primary label. On fork PRs, a maintainer applies the label. See sweep labels and reuse.
  • After merging: PR authors must ensure all GitHub Actions jobs pass. Transient failures often pass on rerun; see how to rerun failed jobs.
中文

感谢你的贡献!

  • **审阅:**如果 PR 修改的文件归属于仓库管理员及 @SemiAnalysisAI/core 之外的 CODEOWNER,请先联系一位有资格的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,再通过 Slack 联系核心维护者。必须严格遵循模板,并保留 As a PR reviewer and CODEOWNER, I have reviewed this and have,才能触发签核验证。
  • **PR 验证:**只有当 PR 在 inferencex-e2e/perf-changelog.yaml 末尾追加了条目,并且恰好带有一个主标签时,才会运行扫描:full-sweep-fail-fast(强烈推荐;canary 加逐矩阵 fail-fast)、full-sweep-enabled(有 canary;矩阵任务在失败后继续运行)或 non-canary-full-sweep-enabled(无 canary,也无 fail-fast)。修饰标签 all-evals、evals-only 和 agentx-fast 必须与主标签一起使用。fork PR 的标签由维护者添加。参见扫描标签与复用。
  • **合并后:**PR 作者必须确保所有 GitHub Actions 任务通过。临时性失败通常可以通过重新运行恢复;参见重新运行失败任务的说明。

@Oseltamivir Oseltamivir added the full-sweep-fail-fast Full sweep with canary gate; first failure cancels the rest of that matrix (recommended) label Oct 23, 2026
…gb200-dspark-b200parity

# Conflicts:
#	inferencex-e2e/perf-changelog.yaml

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the inline findings, I compared the new GB200 recipe with the merged B200 recipe. They differ only in name, gpu_type and gpus_per_node. The fp8 drafter KV, the health-check settings and the golden-AL comments all come unchanged from B200, and the search space matches B200's entry. I found nothing GB200-specific in them to flag.

Extended reasoning...

The PR adds a GB200 srt-slurm recipe, a master-config entry and a perf-changelog block for MiniMax-M3.1-Flash on vLLM. It touches no security-sensitive code. A diff against the merged B200 sibling recipe shows only the name and GPU-topology fields changed, and the master-config search space matches B200 line for line.

Findings marked 🟡 are optional suggestions and need no follow-up push.

Comment thread inferencex-e2e/perf-changelog.yaml Outdated
description:
- "Add day-0 MiniMax-M3.1-Flash (MiniMaxAI/MiniMax-M3.1-Flash, NVFP4 experts + NVFP4 KV cache) AgentX on GB200, matching the B200 recipe (#4426) with the arm64 build of the same day-0 vLLM image (minimax-m31-flash-arm64-cu134)."
- "DSpark with the built-in drafter (probabilistic drafting, FLASH_ATTN drafter, fp8 drafter KV); TP4 c1-c32 drafting 7 tokens (golden AL 4.04); DEP4 (TP1 x DP4 + EP4 behind vllm-router) c64-c128 drafting 3 tokens (golden AL 2.88)."
pr-link: TBD

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔴 The changelog validator will fail this PR because the new entry's pr-link: TBD is not an accepted placeholder. The merge-prep step will also reject it. validate_perf_changelog.py:147 accepts only the PR's own URL or a PR_LINK_PLACEHOLDERS value (XXX or .../pull/XXX). Fix: set the link to https://github.com/SemiAnalysisAI/InferenceX/pull/XXX or to this PR's real URL.

Why this was flagged

The diff appends pr-link: TBD at inferencex-e2e/perf-changelog.yaml:10921. For each new PR entry, validate_perf_changelog.py:147-150 raises new PR entry must use '<expected>' or an XXX placeholder; found 'TBD', because PR_LINK_PLACEHOLDERS (validate_perf_changelog.py:22-25) holds only XXX and https://github.com/SemiAnalysisAI/InferenceX/pull/XXX. The merge-prep canonicalize_appended_links in prepare_perf_changelog_merge.py:108-111 also raises appended entry ... has unexpected pr-link 'TBD' and does not rewrite the link to the PR URL. As a result, changelog validation and the reuse-assisted merge both fail for this PR. A placeholder in the accepted form would pass and be rewritten to the real link automatically.

Verification: Trigger: the PR is merged while the appended entry still has pr-link: TBD (inferencex-e2e/perf-changelog.yaml). The PR-time CI check does not catch this. validate_added_pr_link (validate_perf_changelog.py:193) raises at line 147, because PR_LINK_PLACEHOLDERS (lines 22-25) contains only XXX and https://github.com/SemiAnalysisAI/InferenceX/pull/XXX, so the merge aborts.

Comment on lines +5547 to +5549
# MiniMax-M3.1-Flash AgentX on GB200: the B200 recipe and search space on the
# GB200 NVL4 tray, with the day-zero arm64 CUDA 13.4 build of the same image
# (manifest sha256:86f582dae25ea92802353727164ae4eb03b37b18baf9119b805ffaec2a7ef07c).

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 (optional) Maintainers get a header and provenance comment above the new master-config entry, which AGENTS.md forbids in every file. The three-line block at nvidia-master.yaml:5547-5549 describes the topology and says the entry reuses "the B200 recipe and search space". It also cites the B200 image's manifest digest as its source. Fix: delete the comment block above minimaxm31flash-fp4-gb200-vllm-agentic-dspark:. The B200 lineage and manifest digest are already in the perf-changelog entry and PR description.

Why this was flagged

The diff adds a comment block at inferencex-e2e/configs/nvidia-master.yaml:5547-5549 directly above the new minimaxm31flash-fp4-gb200-vllm-agentic-dspark key. AGENTS.md:60-66 ('Code comments (mandatory)') bans header comments above a recipe or section and bans comments that describe the topology or config. It also bans history comments about where code was derived from, saying git history and perf-changelog.yaml are the record. The block does all three: it describes the GB200 NVL4 tray topology, says the entry is "the B200 recipe and search space", and gives the B200 image manifest digest as provenance. The B200 sibling entry at nvidia-master.yaml:5532 has no such comment, so the new entry breaks both the rule and the nearest existing pattern.

Verification: The diff adds a three-line comment block above the new key at inferencex-e2e/configs/nvidia-master.yaml:5547-5549. AGENTS.md's "Code comments (mandatory)" section applies "to every file, including recipes, configs". The block breaks its "No header comments" and "No history" rules, but nothing at runtime is affected.

@github-actions

Copy link
Copy Markdown
Contributor

@Oseltamivir

Copy link
Copy Markdown
Collaborator Author

/use 39942082663

@github-actions

github-actions Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

@Oseltamivir staged run 39942082663.

This run remains available across future /stage-results requests. Staging the same run ID again updates its staged data. Staging workflow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-sweep-fail-fast Full sweep with canary gate; first failure cancels the rest of that matrix (recommended)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant