Skip to content

[Klaud Cold] minimaxm31flash-fp4-gb200-sglang-agentic-dspark: day-zero MiniMax-M3.1-Flash GB200 SGLang recipe - #4444

Merged
Oseltamivir merged 3 commits into
mainfrom
feat/minimaxm31flash-gb200-sglang
Oct 24, 2026
Merged

Oseltamivir merged 3 commits into
mainfrom
feat/minimaxm31flash-gb200-sglang

Conversation

@Oseltamivir

Copy link
Copy Markdown
Collaborator

Summary

Day-zero MiniMax-M3.1-Flash (MiniMaxAI/MiniMax-M3.1-Flash, NVFP4) AgentX on GB200 with SGLang, following the SGLang cookbook: https://docs.sglang.io/cookbook/autoregressive/MiniMax/MiniMax-M3.1 (config source: docs/src/snippets/configs/MiniMaxAI/minimax-m3.1.jsx).

  • Image: lmsysorg/sglang:dev-minimax-m31-flash, pinned by digest (verified on Docker Hub 2026-10-24).
  • Serve flags: the cookbook's GB300 cells (the cookbook has no GB200 cell): Balanced (TP4, TRT-LLM routed MoE) for conc 1–32 and High-Throughput (TP4 + EP4 MegaMoE) for conc 64–128. The High-Throughput arm takes B200's sm_100 memory settings (--mem-fraction-static 0.75, --cuda-graph-max-bs-prefill 16384), since B300's settings ran out of memory capturing prefill graphs on B200.
  • Common flags: --speculative-algorithm DSPARK --speculative-use-block-verification, --cuda-graph-backend-prefill breakable, minimax-m3 reasoning and tool parsers, --tokenizer-worker-num 8.
  • Speculative decoding: seven-token DSpark (--speculative-dspark-block-size 7, the bundled draft's dspark_block_size). It's set explicitly so throughput runs resolve synthetic acceptance from minimaxm31flash_dspark.yaml ([Klaud Cold] Add MiniMax-M3.1-Flash DSpark golden AL curve and SPEED-Bench collector / [Klaud Cold] 新增 MiniMax-M3.1-Flash DSpark 黄金 AL 曲线与 SPEED-Bench 采集脚本 #4425): AL 4.04 at 7 tokens, thinking on (adaptive, the default).
  • Scheduler batch: the TP4 arm uses 2× CONC for AgentX subagent fan-out, capped at the cookbook's 128, with the decode graph batch matching it.
  • Checked locally: infx generate binds every matrix point to exactly one recipe variant, with SGLANG_SIMULATE_ACC_LEN=4.04.

vLLM siblings: #4419 (GB300), #4420 (MI355X), #4421 (B300), #4422 (H100), #4423 (H200), #4426/#4431 (B200), #4433 (GB200).

…1-Flash SGLang AgentX on GB200

Serve flags follow the SGLang cookbook's MiniMax-M3.1 cells with the day-zero
dev-minimax-m31-flash image. Seven-token DSpark with synthetic acceptance from
the minimaxm31flash_dspark golden curve.
@Oseltamivir Oseltamivir added the full-sweep-fail-fast Full sweep with canary gate; first failure cancels the rest of that matrix (recommended) label Oct 23, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

  • Review: If this PR changes files owned by someone other than a repository admin or @SemiAnalysisAI/core, ask one eligible CODEOWNER to complete the latest PR_REVIEW_CHECKLIST.md before contacting a core maintainer on Slack. Follow the template exactly, including As a PR reviewer and CODEOWNER, I have reviewed this and have, so sign-off verification triggers.
  • PR verification: Sweeps run only when the PR appends an inferencex-e2e/perf-changelog.yaml entry and carries exactly one primary label: full-sweep-fail-fast (strongly recommended; canary plus per-matrix fail-fast), full-sweep-enabled (canary; matrix jobs continue after a failure), or non-canary-full-sweep-enabled (no canary or fail-fast). The modifiers all-evals, evals-only, and agentx-fast require a primary label. On fork PRs, a maintainer applies the label. See sweep labels and reuse.
  • After merging: PR authors must ensure all GitHub Actions jobs pass. Transient failures often pass on rerun; see how to rerun failed jobs.
中文

感谢你的贡献!

  • **审阅:**如果 PR 修改的文件归属于仓库管理员及 @SemiAnalysisAI/core 之外的 CODEOWNER,请先联系一位有资格的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,再通过 Slack 联系核心维护者。必须严格遵循模板,并保留 As a PR reviewer and CODEOWNER, I have reviewed this and have,才能触发签核验证。
  • **PR 验证:**只有当 PR 在 inferencex-e2e/perf-changelog.yaml 末尾追加了条目,并且恰好带有一个主标签时,才会运行扫描:full-sweep-fail-fast(强烈推荐;canary 加逐矩阵 fail-fast)、full-sweep-enabled(有 canary;矩阵任务在失败后继续运行)或 non-canary-full-sweep-enabled(无 canary,也无 fail-fast)。修饰标签 all-evals、evals-only 和 agentx-fast 必须与主标签一起使用。fork PR 的标签由维护者添加。参见扫描标签与复用。
  • **合并后:**PR 作者必须确保所有 GitHub Actions 任务通过。临时性失败通常可以通过重新运行恢复;参见重新运行失败任务的说明。

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.

Comment thread inferencex-e2e/perf-changelog.yaml Outdated
- "GB200 has no cookbook cell; it runs the GB300 (4-GPU) layouts, with B200's sm_100 High-Throughput memory settings (mem-fraction-static 0.75, prefill graphs to 16384)."
- "Seven-token DSpark (the bundled draft's dspark_block_size); throughput runs use synthetic acceptance from the minimaxm31flash_dspark golden curve (AL 4.04 at 7 draft tokens, #4425)."
- "Search space: Balanced TP4 at conc 1-32; TP4 + EP4 at conc 64-128."
pr-link: TBD

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 (optional) The PR's changelog check will reject this entry, blocking CI, so the new config is never collected. pr-link: TBD is not an accepted placeholder. validate_added_pr_link only takes the PR's own URL or an XXX placeholder. Fix: set pr-link to https://github.com/SemiAnalysisAI/InferenceX/pull/XXX, or to the real PR URL.

Why this was flagged

The new tail entry at inferencex-e2e/perf-changelog.yaml:11019 sets pr-link: TBD. On PR runs, compare_entries calls validate_added_pr_link for each appended entry (inferencex-e2e/infx/workflows/validate_perf_changelog.py:192-193). With pr_number set, any link that is neither in PR_LINK_PLACEHOLDERS ({"XXX", "https://github.com/SemiAnalysisAI/InferenceX/pull/XXX"}, lines 22-25) nor the expected PR URL raises ChangelogValidationError "new PR entry must use ... or an XXX placeholder; found 'TBD'" (lines 146-150). On main-branch runs the check needs CANONICAL_PR_LINK, which also rejects 'TBD' (lines 141-143). So the changelog validation fails, and result collection for minimaxm31flash-fp4-gb200-sglang-agentic-dspark cannot go ahead. No other entry in the file uses TBD. The ChangelogEntry schema types pr_link as a plain str, so the schema check alone lets it through.

Verification: nit. The trigger is merging this PR with the supported reuse-merge tool. The PR-side check-changelog job does not check pr-link, so CI is not blocked. merge_pr calls canonicalize_changelog(pr, repo) at merge_with_reuse.py:631, outside any try block. With pr_number set, 'TBD' raises ChangelogValidationError, so the reuse merge aborts with a traceback.

Comment on lines +5616 to +5621
# MiniMax-M3.1-Flash AgentX on GB200 with SGLang: day-zero image from the SGLang
# cookbook (https://docs.sglang.io/cookbook/autoregressive/MiniMax/MiniMax-M3.1),
# manifest digest verified 2026-10-24. Serve flags follow the cookbook's
# GB300 Balanced (TP4) and High-Throughput (TP4, EP4) cells; GB200 has no cookbook cell, so the High-Throughput arm takes B200's sm_100 memory settings (mem 0.75, prefill graphs to 16384).
# Seven-token DSpark (bundled draft); synthetic acceptance follows
# infx/golden_al_distribution/minimaxm31flash_dspark.yaml.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 nit (optional): New section-header and provenance comments break AGENTS.md "Code comments" (no header comments above a recipe, override or section; no history or derivation). sweep:cookbook|# (TP4 Balanced|High-Throughput|Balanced:) Examples: the master header at nvidia-master.yaml:5616-5621 cites the cookbook and says "manifest digest verified 2026-10-24", a date after the PR was opened. agentic.yaml:51-52 sits above the TP4 overrides. Fix: delete these blocks and keep only short per-line technical comments. Provenance already lives in perf-changelog.yaml.

Why this was flagged

AGENTS.md lines 64-66 forbid broad comments above a recipe, override or section, and comments describing where values were derived from. The diff adds such comments at several places. One is the 6-line header above minimaxm31flash-fp4-gb200-sglang-agentic-dspark (nvidia-master.yaml:5616-5621), which cites the cookbook and a verification date of 2026-10-24, one day after the PR opened on 2026-10-23. Others are the search-space labels "# Balanced: TP4." and "# High-Throughput: TP4 + EP4 (MegaMoE)." (5634, 5636). The rest are in the recipe: "Serve flags follow the cookbook's GB300..." (agentic.yaml:24-25), and the section headers above the overrides at agentic.yaml:51-52 and 129-130. Maintainers end up with provenance text that the convention keeps in git history and perf-changelog.yaml, and the future-dated provenance claim is unreliable.

Verification: AGENTS.md:60-67 says "No header comments" above a recipe, override, or section and "No history" about where it was derived from. nvidia-master.yaml:5616-5621 adds a 6-line header with provenance and "manifest digest verified 2026-10-24", one day after the PR was opened. agentic.yaml:51-52 and 24-25 add a section header and a provenance comment. Nothing breaks at runtime.

@github-actions

Copy link
Copy Markdown
Contributor

Keep main's entries; reinsert the GB200 SGLang block and append its changelog entry.
@Oseltamivir

Copy link
Copy Markdown
Collaborator Author

/use 39996749965

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

@Oseltamivir staged run 39996749965.

This run remains available across future /stage-results requests. Staging the same run ID again updates its staged data. Staging workflow

@Oseltamivir
Oseltamivir merged commit ceea9fd into main Oct 24, 2026
26 checks passed
@Oseltamivir
Oseltamivir deleted the feat/minimaxm31flash-gb200-sglang branch October 24, 2026 03:45
zijiexia added a commit to zijiexia/InferenceX that referenced this pull request Oct 24, 2026
Resolve the perf-changelog conflict with SemiAnalysisAI#4444 via prepare_perf_changelog_merge.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full-sweep-fail-fast Full sweep with canary gate; first failure cancels the rest of that matrix (recommended)

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant