Added attribute mapping detection #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Geekimo
commented
Jul 13, 2021
Geekimo
commented
- Re-added deleted annotated class detection, and added attribute mapping detection.
- Fixed tests
…jrushlow) This PR was squashed before being merged into the 1.0-dev branch. Discussion ---------- [ci] handle new 5.4 branch & make dev tests green - We don't have a `5.x` branch anymore on `symfony/symfony` - let's use the `dev` version specified in `versions.json` in place of the `5.x` branch. - `SYMFONY_REQUIRE` env param in CI overrides the stability version specified for the run, resulting in a mixed set of versioned packages for each test. e.g. `symfony/http === v5.3.0` && `symfony/twig-bridge === v5.4.x-dev` even though `SYMFONY_SKELETON_STABILITY=dev` is set. - some symfony components now use `psr/log` `^1 || ^2 || ^3` but `doctrine/migrations` still uses `^1`. For migrations tests, because `doctrine/orm` is required after the skeleton has been built, there is a version conflict w/ the locked, `psr/log:2.0` and `doctrine/migrations`. Calling `psr/log:^1.1.4` resolves this issue and allows the tests to run. _contains ``@legacy`` tags for internal use:_ - Remove `psr/log:^1.1.4` as extraDependency in `MakeMigrationsTest` once doctrine/migrations#1184 is merged, tagged, and released. Commits ------- e6b691f [ci] handle new 5.4 branch & make dev tests green
…shlow) This PR was squashed before being merged into the 1.0-dev branch. Discussion ---------- [internal] add route generator for controllers Concept to cleanup templates that depend on route annotations / attributes for better DX when contributing to MakerBundle. The `ResetPasswordController` is an exception due to the existing docBlocks that are generated. Will revisit that controller in the future. Commits ------- 04f9c0b [internal] add route generator for controllers
…reset-password, includes other improvements (jrushlow) This PR was merged into the 1.0-dev branch. Discussion ---------- use password hasher for make:registration & make:reset-password, includes other improvements Use the new password hasher if it exists, or fallback to the old password encoder for `make:reset-password` & `make:registration`. - introduces the concept of using `ClassNameDetails` objects in `make:registration` templates. - adds a new `TemplateComponentsGenerator::getPropertyType($classNameDetails)` object that simplifies using typed properties in templates. _contains ``@legacy`` tags for internal use:_ - Remove `Generator::getControllerBaseClass()` when `FrameworkBundle` min supported version >= 4.1 - make:registration `$passwordHasher` conditional can be removed when min Symfony supported version >=5.3 - make:reset-password `$passwordHasher` conditional can be removed when min Symfony supported version >=5.3 - injected controller var's `password_variable_name` & `use_password_hasher` can be removed when min Symfony supported version >=5.3 refs symfony#821 Commits ------- daa3b45 [make:registration&reset-password] conditionally use password hashers
SimonMarx
merged commit a96ac57
into
SimonMarx:feature/php8-make-entity-attribute-support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.