use password hasher for make:registration & make:reset-password, includes other improvements #923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
reviewed
Jul 6, 2021
src/Resources/skeleton/registration/RegistrationController.tpl.php
Outdated
Show resolved
Hide resolved
src/Resources/skeleton/registration/RegistrationController.tpl.php
Outdated
Show resolved
Hide resolved
jrushlow
commented
Jul 19, 2021
jrushlow
force-pushed
the
feature/password-hasher
branch
2 times, most recently
from
5ee7fc0 to
d2b85d5
Compare
jrushlow
changed the title
2 tasks
weaverryan
reviewed
Jul 20, 2021
src/Maker/MakeRegistrationForm.php
Outdated
| @@ -276,14 +274,24 @@ public function generate(InputInterface $input, ConsoleStyle $io, Generator $gen | |||
| 'Controller\\' | |||
| ); | |||
|
|
|||
| /* | |||
| * @legacy Conditional can be removed when MakerBundle no longer | |||
| * supports Symfony < 6.0 | |||
There was a problem hiding this comment.
Couldn't we drop this once MakerBundle no longer supports 5.2? The thinking is: UserPasswordHasherInterface is new in 5.3. If an app is using 5.3, then we will ALWAYS give them the new class. So once MakerBundle requires 5.3 or higher, we can drop this. That's much sooner than 6.0 :)
There was a problem hiding this comment.
agreed - i was thinking when the old interface is removed, not when the new one was added.. lets do it!
jrushlow
force-pushed
the
feature/password-hasher
branch
from
c43f6bf to
daa3b45
Compare
|
Thanks Jesse! |
Merged
weaverryan
added a commit
that referenced
this pull request
Sep 27, 2021
This PR was merged into the 1.0-dev branch. Discussion ---------- [release] prep 1.34.0 # Release Hi Makers! This release contains a few new features, fixes, and improvements under the hood! Most notably, this release introduces PHP Attribute support for `make:entity` including entities using API Platform, support for the new Symfony Password Hasher in `make:reset-password`, & `make:registration`, and implements stronger return types where possible. Diff: v1.33.0...v1.34.0 Happy making! # Changelog ## [v1.34.0](https://github.com/symfony/maker-bundle/releases/tag/v1.34.0) *September 27th, 2021* ### Feature - [#978](#978) - Adding Entity attribute support - *`@simonmarx`*, *`@geekimo`*, *`@adlpz`*, *`@weaverryan`*, *`@jrushlow`* - [#970](#970) - make PhpCompatUtil::getPhpVersion() public - *`@nikophil`* - [#968](#968) - [make:entity] APIP: use new attribute if exists - *`@nikophil`* - [#963](#963) - add return types for symfony 6 - *`@jrushlow`* - [#925](#925) - [templates] Add void return types - *`@seb`-jean* - [#923](#923) - use password hasher for make:registration & make:reset-password, includes other improvements - *`@jrushlow`* ### Bug Fix - [#974](#974) - Fix method call definition - *`@ajgarlag`* - [#973](#973) - Fix we we typo - *`@karser`* - [#933](#933) - [make:entity] Remove deprecated json_array type from available list types. - *`@bdaler`* - [#930](#930) - Add all missed dependencies to make:reset-password - *`@upyx`* - [#870](#870) - [make:crud] Fix templates path use in include - *`@leblanc`-simon* Commits ------- 2ba83b3 [release] prep 1.34.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the new password hasher if it exists, or fallback to the old password encoder for
make:reset-password&make:registration.ClassNameDetailsobjects inmake:registrationtemplates.TemplateComponentsGenerator::getPropertyType($classNameDetails)object that simplifies using typed properties in templates.contains
@legacytags for internal use:Generator::getControllerBaseClass()whenFrameworkBundlemin supported version >= 4.1$passwordHasherconditional can be removed when min Symfony supported version >=5.3$passwordHasherconditional can be removed when min Symfony supported version >=5.3password_variable_name&use_password_hashercan be removed when min Symfony supported version >=5.3refs #821