[make:entity] APIP: use new attribute if exists #968
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikophil
changed the title
nikophil
force-pushed
the
apip/new-attribute
branch
from
9002796 to
f2a778a
Compare
nikophil
commented
Sep 6, 2021
| @@ -44,7 +44,7 @@ public function regenerateEntities(string $classOrNamespace): void | |||
| { | |||
| try { | |||
| $metadata = $this->doctrineHelper->getMetadata($classOrNamespace); | |||
| } catch (MappingException | LegacyCommonMappingException | PersistenceMappingException $mappingException) { | |||
| } catch (MappingException|LegacyCommonMappingException|PersistenceMappingException $mappingException) { | |||
There was a problem hiding this comment.
just fixing CS problem
|
Thanks Nicolas! |
Merged
weaverryan
added a commit
that referenced
this pull request
Sep 27, 2021
This PR was merged into the 1.0-dev branch. Discussion ---------- [release] prep 1.34.0 # Release Hi Makers! This release contains a few new features, fixes, and improvements under the hood! Most notably, this release introduces PHP Attribute support for `make:entity` including entities using API Platform, support for the new Symfony Password Hasher in `make:reset-password`, & `make:registration`, and implements stronger return types where possible. Diff: v1.33.0...v1.34.0 Happy making! # Changelog ## [v1.34.0](https://github.com/symfony/maker-bundle/releases/tag/v1.34.0) *September 27th, 2021* ### Feature - [#978](#978) - Adding Entity attribute support - *`@simonmarx`*, *`@geekimo`*, *`@adlpz`*, *`@weaverryan`*, *`@jrushlow`* - [#970](#970) - make PhpCompatUtil::getPhpVersion() public - *`@nikophil`* - [#968](#968) - [make:entity] APIP: use new attribute if exists - *`@nikophil`* - [#963](#963) - add return types for symfony 6 - *`@jrushlow`* - [#925](#925) - [templates] Add void return types - *`@seb`-jean* - [#923](#923) - use password hasher for make:registration & make:reset-password, includes other improvements - *`@jrushlow`* ### Bug Fix - [#974](#974) - Fix method call definition - *`@ajgarlag`* - [#973](#973) - Fix we we typo - *`@karser`* - [#933](#933) - [make:entity] Remove deprecated json_array type from available list types. - *`@bdaler`* - [#930](#930) - Add all missed dependencies to make:reset-password - *`@upyx`* - [#870](#870) - [make:crud] Fix templates path use in include - *`@leblanc`-simon* Commits ------- 2ba83b3 [release] prep 1.34.0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
here is an update to use new
ApiResourceattribute from api platofrm v3 when providing--api-resourceflag inmake:entitycommand.This cannot be tested yet since v3 is not released