[make:auth] support new password hasher interface #824
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrushlow
commented
Feb 23, 2021
src/Generator.php
Outdated
Comment on lines
48
to
58
| if (null === $phpCompatUtil) { | ||
| $templateClassFormatter = new TemplateClassFormatter($this->phpCompatUtil); | ||
|
|
||
| // trigger_deprecation('symfony/maker-bundle', '1.25', 'Initializing Generator without providing an instance of PhpCompatUtil is deprecated.'); | ||
| } | ||
|
|
||
| $this->templateClassFormatter = $templateClassFormatter; |
jrushlow
force-pushed
the
fix/deprecated-password-encoder
branch
from
e3bb8f8 to
16050c0
Compare
weaverryan
added a commit
that referenced
this pull request
Mar 30, 2021
…dUserInterface (jrushlow) This PR was squashed before being merged into the 1.0-dev branch. Discussion ---------- [make:user] user entities implement PasswordAuthenticatedUserInterface Starting in Symfony 5.3 - PR symfony/symfony#40267 introduces the new `PasswordAuthenticatedUserInterface` ~& `LegacyPasswordAuthenticatedUserInterface`~ aimed at decoupling passwords from the `UserInterface`. - Generated `User` entity implements `PasswordAuthenticatedUserInterface` if it exists. - Adds correct type hint to the generated `UserRepository::upgradePassword()` method. Authentication related changes are handled in #824 // cc @chalasr Commits ------- f9d9d03 [make:user] user entities implement PasswordAuthenticatedUserInterface
jrushlow
force-pushed
the
fix/deprecated-password-encoder
branch
from
16050c0 to
fcd6c5a
Compare
jrushlow
force-pushed
the
fix/deprecated-password-encoder
branch
from
fcd6c5a to
0c5913f
Compare
|
@jrushlow any update? |
|
howdy @gimler, we have introduced some new functionality recently that improves DX and make implementing the new security system (including the hasher interfaces) as a whole much more easier. Don't quote me on this, but my goal is to have this wrapped up this week. PR #923 has to come first so this can be refactored to use some of the new internal functionality in End of the day, I'm shooting to have this released along with other fixes and improvements later this week*. If all goes as planned, MakerBundle will then be fully "compliant" with the new authentication system as of Symfony * Everything is subject to change |
jrushlow
force-pushed
the
fix/deprecated-password-encoder
branch
from
0c5913f to
638432c
Compare
jrushlow
force-pushed
the
fix/deprecated-password-encoder
branch
from
0f27385 to
c190f34
Compare
|
outdated and functionality already added in separate PR's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds support for the new
UserPasswordHasherInterfaceinmake:auth. If the new interface exists, it is automatically used.introduces the concept of
TemplateClassDetailsthat has getter methods that return preformatted strings for our most common template variable types.Depends on:
fixes #821