Refactoring: Menu Repository

[lbajsarowicz]

1. $model->save() and $model->delete() breaks SOLID principle of single responsibility. Although it's not introduced to Coding Standard yet, the Resource Model should be used for operating with the database. Do not use getResource()->save() in Model magento/magento-coding-standard#187
2. Add Exceptions to the interface, as these are part of interface API.
3. Improve verbosity and readability of the Repository (Object - > Menu etc.)

[Igloczek]

Internal ticket DEV-69361

[TM18]

@lbajsarowicz was this ticket closed on purpose?

[lbajsarowicz]

A month passed by without any feedback.
I'm going to fork and develop the MegaMenu on my own.

[mcjwsk]

Łukasz, please don't be offended! We are glad to see your pull requests. We promise to improve. Let's develop the module together.

[lbajsarowicz]

No emotions involved. It's just maintainability as I regularly review all my PRs to check the progress.
If you like - just do the Cherry Pick and proceed, I need to have an easy way to extend your module, but to be able to do so - I need to clean up the rubbish that is already there. When reviewing cleanup takes > 30 days, it's going to take months to introduce serious changes to the code.

[mcjwsk]

Okay, seems reasonable, but give us a second chance. I appreciate your involvement and I want to have you as a contributor here :).

[lbajsarowicz]

Don't make it hang too long.