[69364] Feature: Repository responsibility of children nodes removal #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Internal ticket DEV-69364 |
TM18
suggested changes
Aug 26, 2020
|
@lbajsarowicz could you please proceed with the requested changes? |
|
@lbajsarowicz any updates? |
…moval' into feature/repository-node-removal
…-node-removal # Conflicts: # Model/MenuRepository.php
jochhop
approved these changes
Oct 1, 2020
andrzejborkowski
changed the title
|
@lbajsarowicz could you merge current develop into your branch, please? |
rafdol
reviewed
Feb 9, 2021
| * @return \Magento\Framework\Controller\ResultInterface|ResponseInterface | ||
| * @throws \Magento\Framework\Exception\NotFoundException | ||
| * @return ResultInterface|ResponseInterface | ||
| * @throws NotFoundException |
There was a problem hiding this comment.
Where is this exception (NotFoundException) thrown? I see only CouldNotDeleteException, InvalidArgumentException, NoSuchEntityException.
rafdol
reviewed
Feb 9, 2021
| try { | ||
| $id = $this->getRequestMenuId(); |
There was a problem hiding this comment.
The better name for this variable is $menuId in my opinion.
|
@lbajsarowicz please proceed with the requested changes, then we'll review the code again and merge it to develop branch. Thank you! |
|
I don't have time to finish this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR depends on #111
With this PR I removed the responsibility of removing children nodes from Controller, to Repository.
Controller's only responsibility should be navigating to the right resource / service to handle the request. Thus, there should be no business logic in Controller.
That is why I extracted this responsibility to Repository that responsibility is to maintain resources.
Also: replaced some weird "magic" behind the filtering with simple collection filter.