Skip to content

fix(report-ui): fix language and onHover Tooltip alignment#961

Merged
Komzpa merged 2 commits into
Soju06:mainfrom
huzky-v:fix/ui-fix-on-report-page
Jun 8, 2026
Merged

fix(report-ui): fix language and onHover Tooltip alignment#961
Komzpa merged 2 commits into
Soju06:mainfrom
huzky-v:fix/ui-fix-on-report-page

Conversation

@huzky-v

@huzky-v huzky-v commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator

Summary

Translate the /reports dashboard page from Portuguese to English user-facing labels, extract a shared ChartTooltip component to unify chart tooltip styling, and revert the CI placeholder-check approach in favor of job-level if gating.

Type of change

  • fix: — bug fix (no behavior change beyond the bug)
  • feat: — new user-facing feature or capability
  • refactor: — internal refactor (no behavior change, no API change)
  • docs: — documentation only
  • chore: / ci: / build: — tooling, CI, packaging
  • test: — test-only change
  • Breaking change

Linked issue:

OpenSpec

  • This PR includes / updates an OpenSpec change
  • Not applicable — bug fix that matches the existing spec
  • Not applicable — docs / CI / chore only
  • This PR touches a codex-faithful path (image pipeline, request/response
    shape, SSE framing, OAuth flow) and preserves upstream-equivalent behavior

Change directory: openspec/changes/translate-reports-ui-english/

Changes

  • Reports page: translate all page-owned Portuguese labels to English (Cost Report, Usage history by date range, Loading..., Total Cost, Cost by Day, Tokens by Day, Distribution by Model, Daily Breakdown, etc.)
  • Extract shared ChartTooltip component (chart-tooltip.tsx) with Partial<TooltipContentProps> typing for recharts v3.8.1 compatibility, replacing inline tooltip styling in cost-per-day-chart.tsx, tokens-per-day-chart.tsx, and model-distribution-donut.tsx
  • CI: revert the placeholder-step approach for pytest/postgres matrix jobs; use job-level if: needs.changes.outputs.backend == 'true' instead, removing the skip steps and per-step if guards
  • Remove obsolete OpenSpec change create-pytest-required-check-placeholders/ and its regression tests
  • Add OpenSpec change translate-reports-ui-english/ with proposal, delta spec, and tasks
  • Sync frontend-architecture main spec with the new reports-page English wording requirements

Test plan

# Frontend type-check
cd frontend && npx tsc -b

# OpenSpec validation
openspec validate translate-reports-ui-english --strict

# Existing backend tests
uv run pytest tests/ -q

Checklist

  • Title is in Conventional Commits format (<type>(<scope>)?: <subject>).
  • Linked the related issue / discussion above.
  • Added or updated tests covering the change.
  • Ran uv run pre-commit run local-ci --hook-stage manual --all-files or the relevant make <target> subset locally.
  • If touching specs: openspec validate --specs passes and /opsx:verify is clean.
  • CHANGELOG is not edited by hand (release-please handles it).
螢幕截圖 2026-06-08 18 22 21 螢幕截圖 2026-06-08 20 00 00

@huzky-v

huzky-v commented Jun 8, 2026

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 🚀

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@Soju06 Soju06 added the 🤖 codex: ok [@codex review] says no issues found. label Jun 8, 2026
@Komzpa
Komzpa merged commit 094d47b into Soju06:main Jun 8, 2026
25 checks passed
@huzky-v
huzky-v deleted the fix/ui-fix-on-report-page branch June 9, 2026 03:09
@Soju06 Soju06 mentioned this pull request Jun 16, 2026
6 tasks
vitalNohj pushed a commit to vitalNohj/codex-lb that referenced this pull request Jul 17, 2026
* fix(report-ui): fix non-English content to English for consistency

* fix: use tooltip to align the project style
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🤖 codex: ok [@codex review] says no issues found.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants