-
Notifications
You must be signed in to change notification settings - Fork 5
update _modelchain_ac_model for multi array inverters #109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
We'll need to wait for pvlib/pvlib-python#1157 otherwise we'll have to adjust the logic below to not return a list if solarperformanceinsight/api/solarperformanceinsight_api/compute.py Lines 89 to 111 in 0a7a476
|
Merged that PR. Do you want an alpha-3 now? |
I think there is still the issue raised in #119. I'll try and track it down and raise in pvlib |
alorenzo175
added a commit
to alorenzo175/solarperformanceinsight
that referenced
this issue
Feb 5, 2021
a4 because pvlib/pvlib-python#1162 is required along with a tbd issue for computing from effective irradiance closes SolarPerformanceInsight#119 closes SolarPerformanceInsight#109 also adds real tests of the pvlib modelchain to catch errors there
alorenzo175
added a commit
that referenced
this issue
Feb 8, 2021
* update for pvlib 0.9.0a4 a4 because pvlib/pvlib-python#1162 is required along with a tbd issue for computing from effective irradiance closes #119 closes #109 also adds real tests of the pvlib modelchain to catch errors there * mypy * test more modelchain configurations * fix when missing poa global or solar position for from_effective_irr * make sure poa_global is NaN not None * use pvlib 0.9.0a4 * comment update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
pvlib/pvlib-python#1147 and pvlib/pvlib-python#1150 changed the object oriented api for the new multi-array inverter functions. Now you just pass "sandia" or "pvwatts" and the objects determine which function they should call. So SPI needs to update
PVWattsInverterParameters._modelchain_ac_model
andSandiaInverterParameters._modelchain_ac_model
. The change is available inv0.9.0-alpha.2
The text was updated successfully, but these errors were encountered: