update for pvlib 0.9.0a4 #124
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a4 because pvlib/pvlib-python#1162 is required along with a tbd issue for computing from effective irradiance closes SolarPerformanceInsight#119 closes SolarPerformanceInsight#109 also adds real tests of the pvlib modelchain to catch errors there
Codecov Report
@@ Coverage Diff @@
## main #124 +/- ##
==========================================
- Coverage 91.68% 91.30% -0.38%
==========================================
Files 75 75
Lines 2609 2669 +60
Branches 200 207 +7
==========================================
+ Hits 2392 2437 +45
- Misses 189 202 +13
- Partials 28 30 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
wholmgren
approved these changes
Feb 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
a4 because pvlib/pvlib-python#1162 is required
along with a tbd issue for computing from effective irradiance
closes #119 closes #109
also adds real tests of the pvlib modelchain to catch errors there