add ci tests #26
add ci tests #26
Conversation
tests/test_singularity_containers.py
Outdated
| @@ -0,0 +1,33 @@ | |||
| #from spikeinterface.extractors import toy_example | |||
There was a problem hiding this comment.
Ben, I would move this file to spikeinterface/sorters/tests.
We choose to put testing file "inplace" in the relative of the submodule.
There was a problem hiding this comment.
That's fine as long as we can keep this ci here
|
@vncntprvst, @chyumin, @JuliaSprenger do you think you could use this structure to help put together functioning tests for each non-GPU singularity container? |
|
I agree with @samuelgarcia that we should move this over to spikeinterface, but it is more convenient to develop here for now. We can move it over once it is passing. |
yes definitely! thank you |
| kwargs = dict(recording=recording2, verbose=True, singularity_image=True) | ||
|
|
||
|
|
||
| @pytest.mark.xfail(reason="FAILING: investigate why") |
There was a problem hiding this comment.
This is happening because of inconsistent naming format:
spykingcircusused to call run_sorterspyking_circusas python modulespyking-circusas image name
I have created this PR to properly raise the error
There was a problem hiding this comment.
I changed SORTER_DOCKER_MAP in run_sorter.py from spikeinterface for tests.
We need to unify naming format for spyking-cirucs
There was a problem hiding this comment.
Also I'm getting error using data from generate_recording for spyking-circus.
When I change to toy data it works well:
se.toy_example(
duration=30,
seed=0,
num_channels=32,
num_segments=1
)
There was a problem hiding this comment.
strange! @alejoe91, do you have any idea why one might work and not the other?
There was a problem hiding this comment.
The image runs well, but It was raising here when extracting output.
I could see different result[...].hdf5 files in output folder, but not 'result-merged.hdf5' or 'result.hdf5'
No description provided.