Skip to content

Make module production ready#37

Closed
ihor-sviziev wants to merge 2 commits intoStrategery-Inc:masterfrom
ihor-sviziev:patch-8
Closed

Make module production ready#37
ihor-sviziev wants to merge 2 commits intoStrategery-Inc:masterfrom
ihor-sviziev:patch-8

Conversation

@ihor-sviziev
Copy link
Collaborator

For production purpose we need to have good working module.

This PR doing following changes:

  1. Hides toolbar (pagination was hidden in Fix selector for pagination #30, but limit appeared back, it's not needed when infinite scroll is enabled)
  2. Removing "Congratulations, you've reached the end of the internet." text. On real production website it's better just not to add anything

@gsomoza
Copy link
Contributor

gsomoza commented Jun 21, 2018

Thanks.

  1. This makes sense, we'll merge together with Fix selector for pagination #30
  2. Most of our customers do actually seem to use that feature. By providing a default message we make sure our users know about the feature, and they can always choose to customized it with a few clicks. Could you extract it from the commit?

@gsomoza gsomoza added this to the 0.3.0 milestone Jun 21, 2018
@gsomoza gsomoza added the test-and-merge For pull requests: test them on clean install, and if they work: merge. label Jun 21, 2018
@ihor-sviziev
Copy link
Collaborator Author

@gsomoza I created new PR #38 with only needed changes. This one I'm closing because of conflicts

Do not hide toolbar at the top
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

test-and-merge For pull requests: test them on clean install, and if they work: merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants