Skip to content

Hide toolbar by default#38

Merged
gsomoza merged 3 commits intoStrategery-Inc:masterfrom
ihor-sviziev:patch-9
Sep 10, 2019
Merged

Hide toolbar by default#38
gsomoza merged 3 commits intoStrategery-Inc:masterfrom
ihor-sviziev:patch-9

Conversation

@ihor-sviziev
Copy link
Collaborator

This PR hides toolbar (pagination was hidden in #30, but limit appeared back, it's not needed when infinite scroll is enabled)

@gsomoza gsomoza added this to the 0.3.0 milestone Jun 22, 2018
@gsomoza gsomoza added the test-and-merge For pull requests: test them on clean install, and if they work: merge. label Jun 22, 2018
Do not hide toolbar at the top
@ihor-sviziev
Copy link
Collaborator Author

FYI I updated selector for toolbar, because following blocks disappeared:
capture 2018-06-01 at 14 22 35

@gsomoza
Copy link
Contributor

gsomoza commented May 8, 2019

@ihor-sviziev I'm a bit worried about merging this and that suddenly a lot of things would change on websites that were relying on the old defaults.

I think the best way to avoid this effect is to create a migration script that will copy the old defaults into the default store config (in the database) – only when upgrading from an older version of the module.

Is that something you'd be willing to add to your pull request?

The other alternative is to wait with these changes until we release a new major version of the extension. Or if you have any other suggestions let's discuss.

@gsomoza gsomoza added help wanted and removed test-and-merge For pull requests: test them on clean install, and if they work: merge. labels May 8, 2019
@gsomoza gsomoza modified the milestones: 0.3.0, 0.2.6, 0.3.1 May 8, 2019
@ihor-sviziev
Copy link
Collaborator Author

Hi,

Good idea to add setup upgrade script, but I don't have time for doing that. I don't mind if you'll include it in next major release

@gsomoza
Copy link
Contributor

gsomoza commented May 9, 2019

Oops, I ended up bumping major version on the last release anyway and forgot to merge this one (🤦‍♂). I think I might release this one alone with another major bump anyway, but I'll wait a bit to see if any other PRs come in first.

@gsomoza gsomoza modified the milestones: 0.3.1, 0.4.0 May 9, 2019
@gsomoza gsomoza merged commit 660dc44 into Strategery-Inc:master Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants