Skip to content

Fix: Handle whitespace-only tags from Proxmox API to prevent false Terraform diffs #529

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tinyblargon merged 1 commit into from
Dec 16, 2025
Merged

Fix: Handle whitespace-only tags from Proxmox API to prevent false Terraform diffs #529

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions proxmox/type__tag.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,19 @@ func (new Tags) mapToApiUpdate(current *Tags) (string, bool) {
}

func (Tags) mapToSDK(tags string) Tags {
tmpTags := strings.Split(tags, ";")
typedTags := make(Tags, len(tmpTags))
for i, e := range tmpTags {
typedTags[i] = Tag(e)
// Handle Proxmox API bug: sometimes returns " " (whitespace) for VMs with no tags
trimmed := strings.TrimSpace(tags)
if trimmed == "" {
return Tags{}
}

tmpTags := strings.Split(trimmed, ";")
typedTags := make(Tags, 0, len(tmpTags))
for _, tag := range tmpTags {
// Trim whitespace from each tag and skip empty tags
if trimmedTag := strings.TrimSpace(tag); trimmedTag != "" {
typedTags = append(typedTags, Tag(trimmedTag))
}
}
return typedTags
}
Expand Down