Fix: Handle whitespace-only tags from Proxmox API to prevent false Terraform diffs #529
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Proxmox API sometimes (when you set tag for VMs/containers and then remote it) returns
"tags": " "(a single space character) for VMs/containers that have no tags set. This causes false diffs in Terraform when the provider compares the state with the configuration:The issue occurs because the SDK's
mapToSDKfunction was treating the whitespace string as a valid tag, creating aTagsslice with a single tag containing a space character.Solution
Updated
Tags.mapToSDK()inproxmox/type__tag.goto:Tags{}when the input is only whitespaceThis ensures that when Proxmox returns
"tags": " ", it's correctly interpreted as "no tags" rather than "one tag with a space".Test
Before:
After: