test: Qemu Tags, test bug fix #532
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tinyblargon
added
modifies/go
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds test coverage for a Proxmox API bug fix related to Qemu VM tags. In some versions of Proxmox, the API returns a space character (" ") instead of an empty string when a VM has no tags, which needed special handling.
- Adds three test cases to validate tag parsing behavior
- Tests cover the bug scenario (space character), empty string, and normal tag parsing
- Verifies the fix implemented in the
mapToSDKmethod that trims whitespace
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds tests for #529