revert: #452 #531
Merged
revert: #452 #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tinyblargon
added
type/bug
modifies/go
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts optimization #452 due to issues with inconsistent error parsing between the error body and error header in the Proxmox API, as referenced in issue #1469.
Key Changes:
- Reverts the
exists_Unsafemethod to useGetResourceListto check if a guest ID exists - Preserves the optimized implementation as a commented-out FIXME block for future reference once error parsing inconsistencies are resolved
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert optimization as it causes issues due to inconsistent error parsing.
Related to Telmate/terraform-provider-proxmox#1469