Skip to content

revert: #452 #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tinyblargon merged 1 commit into from
Dec 16, 2025
Merged

revert: #452 #531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions proxmox/config__guest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -279,16 +279,28 @@ func (id GuestID) ExistsNoCheck(ctx context.Context, c *Client) (bool, error) {
}

func (id GuestID) exists_Unsafe(ctx context.Context, c *Client) (bool, error) {
_, err := c.GetItemConfigString(ctx, url_NextID+"?vmid="+id.String(), "API", "cluster/nextid",
func(err error) bool {
return err.Error() == guestIDexistsError
})
guests, err := c.GetResourceList(ctx, resourceListGuest)
if err != nil {
if err.Error() == guestIDexistsError {
return false, err
}
for i := range guests {
guest := guests[i].(map[string]any)
if id == GuestID(guest["vmid"].(float64)) {
return true, nil
}
}
return false, err
return false, nil
// FIXME: The code below would be more efficient, but for some users we parse the error body and for others the header. This inconsistency needs to be resolved first.
// _, err := c.GetItemConfigString(ctx, url_NextID+"?vmid="+id.String(), "API", "cluster/nextid",
// func(err error) bool {
// return err.Error() == guestIDexistsError
// })
// if err != nil {
// if err.Error() == guestIDexistsError {
// return true, nil
// }
// }
// return false, err
}

func (id GuestID) String() string { return strconv.Itoa(int(id)) } // String is for fmt.Stringer.
Expand Down