This repository was archived by the owner on Mar 22, 2025. It is now read-only.
(WIP) Feature/docker deploy prod #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
TheDonDope
force-pushed
the
feature/docker-deploy-prod
branch
from
a6e1416 to
9348ef6
Compare
TheDonDope
force-pushed
the
feature/docker-deploy-prod
branch
4 times, most recently
from
eb0ca56 to
7ee81ee
Compare
Setup a docker environment to provide production deployments. The project will spawn two docker containers on `$ docker-compose build`. The first container will install `angular-cli` and do a dist build by running `$ ng serve -prod`. The second container is based on an nginx image and will link the built dist files to a virtual host. Nginx itself will then serve the files on port 80
TheDonDope
force-pushed
the
feature/docker-deploy-prod
branch
from
7ee81ee to
87082f1
Compare
|
Implemented by 712385d |
|
Nginx production build implemented by 0fefa62 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge
Context: angular/angular-cli#885
Credits to @suchja for the base work (https://github.com/suchja/angular-cli-docker)
TODO:
ng build -prod, 2. nginx servedist)docker-compose.ymlfiles for the different containers and environments (similar to https://github.com/danwahlin/angular2-restfulservice)ng serve(similar to https://github.com/suchja/angular-cli-docker)Drawbacks:
Since the
dist-buildcontainer and thenginxcontainer are linked throughnetworks, there is no guarantee on the startup order. Hence, you need to manually start the dist build first and wait for it to finish, and then start the nginx container:Now you should be able to visit the site at http://localhost