-
Notifications
You must be signed in to change notification settings - Fork 1.4k
chore(build): provide docker support #1522
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Provide docker deployment support for separate environments
Fixes a minor formatting issue in the issue template for github
Only one use Example:
But this |
@TheDonDope @mgechev When I started to work on a docker solution for our dev-system, one requirement was to comfortably link a nginx to the app, so the developers can route multiple microservices in our environment to it without manually installing an nginx on their dev system. |
@Shyam-Chen: Yes, the bare minimum is a single |
@sclausen The basic idea is (for production deployment):
Yet, there is still a bit of manual work to do here:
|
I'll merge for now, as he current PR already provides the basic functionality. We can track the NGINX additions in another issue / PR. |
@TheDonDope here is our docker config
and my docker-compose.yml
|
@sclausen Thank you very much! Can you share the contents of your |
@TheDonDope sure, I will post it tomorrow. |
* 'master' of https://github.com/mgechev/angular-seed: chore(build): provide docker support (#1522) use Config.APP_BASE so that it's configurable - write out absolute urls for the sourcemaps because of the way angular2 handles style injection
@TheDonDope here is our nginx conf
|
@sclausen Thank you so much for sharing!!!! :) |
Provide docker deployment support for separate environments
As requested in #1422 this commit provides a basic setup for docker deployment.
Prerequisites:
docker-engine
anddocker-compose
installed$ npm install
, it is not neccessary),cd
into the folder and run one of the below listed deployments.How to run:
For development deployment (
$ npm start
in a docker container) run the following (it will use thedocker-compose.yml
):Open browser at http://localhost:5555/
For production deployment (
$ npm run serve.prod
in a docker container) run the following (explicitly using thedocker-compose.production.yml
):Open browser at http://localhost:5555/
//cc @sclausen @mgechev @ludohenin
P.S.: It would be nice to maybe even provide a production deployment which builds the application via
$ npm run build.prod
and then serving the output in an nginx container.I am working on something like that over here: TheDonDope/crudular#1
Maybe @vyakymenko has some experience on the nginx deployment part?