Skip to content

fix(env): fixup handling of default env service values #314

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TheKevJames merged 1 commit into from
Nov 3, 2021
Merged

fix(env): fixup handling of default env service values #314

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 12 additions & 15 deletions coveralls/api.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,21 +214,18 @@ def load_config_from_environment(self):
if parallel:
self.config['parallel'] = parallel

repo_token = os.environ.get('COVERALLS_REPO_TOKEN')
if repo_token:
self.config['repo_token'] = repo_token

service_name = os.environ.get('COVERALLS_SERVICE_NAME')
if service_name:
self.config['service_name'] = service_name

flag_name = os.environ.get('COVERALLS_FLAG_NAME')
if flag_name:
self.config['flag_name'] = flag_name

number = os.environ.get('COVERALLS_SERVICE_JOB_NUMBER')
if number:
self.config['service_number'] = number
fields = {
'COVERALLS_FLAG_NAME': 'flag_name',
'COVERALLS_REPO_TOKEN': 'repo_token',
'COVERALLS_SERVICE_JOB_ID': 'service_job_id',
'COVERALLS_SERVICE_JOB_NUMBER': 'service_job_number',
'COVERALLS_SERVICE_NAME': 'service_name',
'COVERALLS_SERVICE_NUMBER': 'service_number',
}
for var, key in fields.items():
value = os.environ.get(var)
if value:
self.config[key] = value

def load_config_from_file(self):
try:
Expand Down