🐛 fix comment string as pointed out in #507 #508
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That moment when the blame points back to yourself : I added this file after much investigation on a late night : https://github.com/TypeStrong/atom-typescript/blob/cca22b287e88de8057f7b81936efde1c5f132ffd/settings/typescript.cson (my comment #159 (comment)) Then somehow decided that this file wasn't used : 424b424 👊 myself. Sorry 🌹 An thanks 🌹 |
basarat
added a commit
that referenced
this pull request
Jul 31, 2015
🐛 fix comment string as pointed out in #507
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found out that the grammar relies on
#comments, which is in fact copied from javascript grammar.Adding settings (copied from javascript grammar) ensures that the
commentStartStringis set to//.The grammar options taken from javascript grammar, such as
#commentsI referred to earlier, might not even be necessary, since they are already provided from js grammar, but this has to be investigated and tested further, it should be done in separate PR.