Updated TypeScript version into 2.4.1 #549

ghost · 2017-07-08T19:02:21Z

set noStrictGenericChecks typescript compiler option to true due to Generic Error

set noStrictGenericChecks typescript compiler option to true

ghost · 2017-07-08T19:37:40Z

The fix implied more changes than expected:

Upgraded TypeScript version into 2.4.1
Upgraded TypeScript lib from es5 to es6 due type errors
Added @types/core-js dependency
Modify all imports to pass the tslint
string-literals.ts convertType function, replace type.text by type.value

CHANGED decorators.ts for bad property used CHANGED react.d.ts to solve a known issue

ghost · 2017-07-08T19:59:05Z

Update gruntfile.js to add the compiler options
Change react.d.ts for known FIX link

ghost · 2017-07-08T20:10:15Z

Finally, the build compiles and run the tests with

61 passing (44s)
52 failing

I need to do a lot of changes and fixes, so I think that I've done something wrong in some stage, could a core developer help me to fix this? Thanks

I leave the pull request at this stage to have a changes track

drewwyatt · 2017-07-13T17:10:05Z

Any idea when this will get released? (This is working in my repo)

aciccarello

@aleixmorgadas First of all, thank you for your work and sorry I took so long to review. I know you had to go through a few iterations to get this working. I made a few inline comments but here is a summary.

tslint

I'm not sure why the tslint issues are coming up now but I'd prefer for them to be done in a separate PR. The whitespacing on imports isn't consistent either. Not sure how others feel about this.

tsconfig.json changes

The tsconfig does to define the typeRoots because TypeScript handles the default well enough. The noStrictGenericChecks flag is the simplest fix to the new compilation errors but I would like to fix the type checking.

TS 2.4 specific features

This isn't really the responsibility of this PR but I wanted to note that we should review how new features like string Enums and dynamic imports are handled.

aciccarello · 2017-07-15T18:50:09Z

package.json

@@ -1,7 +1,7 @@
 {
  "name": "typedoc",
  "description": "Create api documentations for typescript projects.",
-  "version": "0.7.1",
+  "version": "0.7.2",


I think this is normally updated on release. Also need to think about whether this is a breaking change.

If this can be undone, I'll do a release.

aciccarello · 2017-07-15T18:50:48Z

src/index.ts

-export {Application} from './lib/application';
-export {CliApplication} from './lib/cli';
+export {Application } from './lib/application';
+export {CliApplication } from './lib/cli';


Why no space in front?

I missed the file, strange that tslint didn't notice it

aciccarello · 2017-07-15T21:03:45Z

tsconfig.json

@@ -16,7 +16,10 @@
    "outDir": "dist/",
    "rootDir": "src/",
    "experimentalDecorators": true,
-    "noStrictGenericChecks": true
+    "noStrictGenericChecks": true,
+    "typeRoots": [


This should not be necessary. TypeScript defaults to this.

aciccarello · 2017-07-15T21:07:54Z

src/test/converter/decorators/decorators.ts

@@ -43,6 +43,6 @@ function decoratorWithParam(value:boolean):MethodDecorator {
 */
 function decoratorWithOptions(options:{name:string}):ClassDecorator {
    return function (target) {
-        target.options = options;
+        target.arguments = target;


So there error here is caused by a lib.es5.d.ts definition. Granted, this is only an example being documented but I'd prefer to update the definition of the target function to include this property.

ghost · 2017-07-15T22:44:57Z

The major changes made are to support TS 2.4 as soon as possible, and then remove the parches to apply the best practices. I'm OK with your decision to first apply the best procedure and then release the new version.

So, I will make a new PR for the tslint issue in the next days. How do you want to procedure with the ts version upgrade?

This reverts commit 1c8e909.

ghost · 2017-07-16T12:00:38Z

👍

abergs · 2017-07-17T08:05:47Z

We're really looking forward to the release of this!

aciccarello · 2017-07-17T14:10:17Z

@aleixmorgadas Thanks for doing the whitespace changes in a separate PR. I made some changes to this PR to tighten the generics type definitions and avoid some of the CI timeouts.

@blakeembrey Can you take a quick look and create a release for this? The version number was already bumped.

CosminIonascu · 2017-07-18T10:30:55Z

Hi, I also need this update, when will be merged?

abergs · 2017-07-18T11:30:42Z

@CosminIonascu In the meantime you can install this pull request by running:

yarn add -D #549/head
or
npm install --save-dev #549/head

CosminIonascu · 2017-07-18T11:47:39Z

Ok, thank's!

abergs · 2017-07-18T12:06:16Z

Also @CosminIonascu, you will ned to build the dist folder in order be able to run the node script:
https://github.com/TypeStrong/typedoc/blob/master/UPDATING.md

blakeembrey · 2017-07-25T18:00:13Z

tsconfig.json

-      "es5",
-      "es2015.collection",
-      "es2015.iterable"
+      "es2016"


es2016? Is there something from es2016 we're using or should this just be es2015?

there was some issues with the types due to the last typescript version, it was solved using the es2016 lib

Which issues?

ghost · 2017-07-26T20:13:52Z

@blakeembrey I've undone the change in the tsconfig.json file, and it works.

There was a lot of errors at the beginning, so they guided me to that change. View all thread to find the reason.

blakeembrey · 2017-07-27T16:42:14Z

@aleixmorgadas The changes you made were invalid JSON. I'll try to check it out for myself.

Edit: Actually, it passes with no changes to the tsconfig.json currently. I'm going to merge.

ghost · 2017-07-27T16:53:56Z

@blakeembrey Yes the commit d3d4d42 had an invalid JSON, but the first errors weren't.

blakeembrey · 2017-07-27T17:07:23Z

@aleixmorgadas As far as I can see, there's no changes to tsconfig.json in the PR I merged. It looks like you undid the changes making it es2016 and it passed. Let me know if I'm not looking at the right thing.

blakeembrey · 2017-07-27T17:08:47Z

Oh, I see what you meant now too. I thought you were undoing the change to demonstrate it failing. The order of the conversation confused me, sorry. I saw your TravisCI link first and I thought that was you showing it fails using the es2015 config. Now I understand that you undid the changes all together (not to es2015 as a demo, then back to es2016).

Aleix Morgadas added 3 commits July 8, 2017 21:01

updated typescript version into 2.4.1

875da78

set noStrictGenericChecks typescript compiler option to true

tslint success

1c8e909

upgraded tsconfig library to es6fix LiteralType

acf7a37

CHANGED gruntfile.js to add compiler options

8adf4dd

CHANGED decorators.ts for bad property used CHANGED react.d.ts to solve a known issue

Aleix Morgadas added 2 commits July 8, 2017 22:47

CHANGED tsconfig.json adding typeRoots

046f94d

REMOVED unnecessary @types/core-js dependency

e486277

aciccarello self-assigned this Jul 10, 2017

aciccarello mentioned this pull request Jul 15, 2017

fix: remove specific version of typescript from dependencies #556

Closed

aciccarello requested changes Jul 15, 2017

View reviewed changes

aciccarello added 3 commits July 15, 2017 22:53

Updated library for stricter generic checks

cfc88d1

Revert tslint edits

cb2f79d

This reverts commit 1c8e909.

fixup! Updated library for stricter generic checks

c3bb32d

aciccarello approved these changes Jul 16, 2017

View reviewed changes

aciccarello assigned blakeembrey Jul 17, 2017

jgravois mentioned this pull request Jul 19, 2017

write the docs! Esri/arcgis-rest-js#2

Closed

blakeembrey reviewed Jul 25, 2017

View reviewed changes

Aleix Morgadas added 2 commits July 26, 2017 10:42

downgrading version into 0.7.1

36e5361

Update tsconfig.json

d3d4d42

Update tsconfig.json

b49ece4

blakeembrey merged commit 3bbf940 into TypeStrong:master Jul 27, 2017

vshjxyz mentioned this pull request Jul 28, 2017

fixes typo AnalyticsFire/mutator-io#1

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updated TypeScript version into 2.4.1 #549

Updated TypeScript version into 2.4.1 #549

ghost commented Jul 8, 2017

ghost commented Jul 8, 2017

ghost commented Jul 8, 2017

ghost commented Jul 8, 2017

drewwyatt commented Jul 13, 2017 •

edited

Loading

aciccarello left a comment

aciccarello Jul 15, 2017

blakeembrey Jul 25, 2017

ghost Jul 26, 2017

aciccarello Jul 15, 2017

ghost Jul 15, 2017

aciccarello Jul 15, 2017

aciccarello Jul 15, 2017

ghost commented Jul 15, 2017

ghost commented Jul 16, 2017

abergs commented Jul 17, 2017

aciccarello commented Jul 17, 2017

CosminIonascu commented Jul 18, 2017

abergs commented Jul 18, 2017

CosminIonascu commented Jul 18, 2017

abergs commented Jul 18, 2017

blakeembrey Jul 25, 2017

ghost Jul 26, 2017

blakeembrey Jul 26, 2017

ghost commented Jul 26, 2017

blakeembrey commented Jul 27, 2017 •

edited

Loading

ghost commented Jul 27, 2017

blakeembrey commented Jul 27, 2017

blakeembrey commented Jul 27, 2017

Updated TypeScript version into 2.4.1 #549

Updated TypeScript version into 2.4.1 #549

Conversation

ghost commented Jul 8, 2017

ghost commented Jul 8, 2017

ghost commented Jul 8, 2017

ghost commented Jul 8, 2017

drewwyatt commented Jul 13, 2017 • edited Loading

aciccarello left a comment

Choose a reason for hiding this comment

tslint

tsconfig.json changes

TS 2.4 specific features

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Jul 15, 2017

ghost commented Jul 16, 2017

abergs commented Jul 17, 2017

aciccarello commented Jul 17, 2017

CosminIonascu commented Jul 18, 2017

abergs commented Jul 18, 2017

CosminIonascu commented Jul 18, 2017

abergs commented Jul 18, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ghost commented Jul 26, 2017

blakeembrey commented Jul 27, 2017 • edited Loading

ghost commented Jul 27, 2017

blakeembrey commented Jul 27, 2017

blakeembrey commented Jul 27, 2017

drewwyatt commented Jul 13, 2017 •

edited

Loading

blakeembrey commented Jul 27, 2017 •

edited

Loading