Skip to content

Conversation

@michalChrobot
Copy link
Collaborator

Purpose of this PR

This PR aims to fix few issues spotted on #ngo-test-failures channel, namely

  • Issue of HelpUrls.NetworkRigidbody has an invalid path! Path: https://docs.unity3d.com/Packages/com.unity.netcode.gameobjects@latest/?subfolder=/manual/advanced-topics/physics.html#networkrigidbody
  • Issue of com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs(1051,52): error CS1503: Argument 1: cannot convert from '(ulong, bool)' to 'ulong'
  • Issue with public accessor on standards check

Jira ticket

N/A

Documentation

N/A

Testing & QA (How your changes can be verified during release Playtest)

Green pass of full CI

Backports

Not really a backport but related to #3773

@michalChrobot michalChrobot self-assigned this Nov 3, 2025
@michalChrobot michalChrobot changed the title Initial change for PR creation ci: [Backport] Fixes to few test failures Nov 3, 2025
Compilation error due to the changed return value of ClientIdToTransportId.
@NoelStephensUnity NoelStephensUnity marked this pull request as ready for review November 3, 2025 18:34
Moving the mid-test #endif and moving it to the bottom.
This reverts commit 1de0142.
@michalChrobot michalChrobot merged commit a8d4f32 into develop Nov 4, 2025
5 of 22 checks passed
@michalChrobot michalChrobot deleted the test-fixture branch November 4, 2025 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants