Skip to content

ci: [Backport] Fixes to few test failures #3774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Nov 4, 2025
+9 −5
Merged

ci: [Backport] Fixes to few test failures #3774

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
f5f8f75
Initial change for PR creation
michalChrobot Nov 3, 2025
d91b7d2
fix
NoelStephensUnity Nov 3, 2025
6854ad4
Merge branch 'develop' into test-fixture
NoelStephensUnity Nov 3, 2025
1de0142
fix
michalChrobot Nov 4, 2025
9cccd8e
Revert "fix"
michalChrobot Nov 4, 2025
69fa3d4
Corrected docs helper URLs
michalChrobot Nov 4, 2025
c971397
corrected logging and code coverage typo
michalChrobot Nov 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .yamato/_run-all.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

#-----------------------------------------------------------------------------------


# This job runs the fastest checks (PVP and code standards)
# This is mainly used to quickly validate the easy mistakes before for example running PR trigger jobs (see _triggers.yml)
run_quick_checks:
Expand Down
5 changes: 4 additions & 1 deletion com.unity.netcode.gameobjects/Runtime/Transports/UTP/UnityTransport.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1048,7 +1048,10 @@ private void ExtractNetworkMetrics()
continue;
}
var transportClientId = NetworkManager.ConnectionManager.ClientIdToTransportId(ngoConnectionId);
ExtractNetworkMetricsForClient(transportClientId);
if (transportClientId.Item2)
{
ExtractNetworkMetricsForClient(transportClientId.Item1);
}
}
}
else
Expand Down
Loading