[IMP] controller_report_xls: general improvements and and code cleanup. t#87779 #1701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated __manifest__.py: set license to LGPL-3, switched to HTTPS for URL, removed unnecessary keys. - Removed outdated copyright header from main controller. - Refreshed es.po with current project metadata. - Deleted redundant translation files (es_ES, es_MX, es_PA, es_VE) to avoid duplication.
- Fix undefined variable 'cssstyle' in get_css_style function - Fix undefined variable 'result' in match_color_index function - Improve string comparison using truthiness instead of empty string check
CDanielSanSeg
force-pushed
the
15.0-general_improvements_to_controller_report_xls
branch
from
d71fbcb to
9cadb79
Compare
CDanielSanSeg
changed the title
luisg123v
requested changes
Jul 3, 2025
|
@emtz10 para probar que no nos rompa nada en villa |
|
tiene razón Luis G, creo que podemos eliminar el dir de controllers, no se esta usando @luisg123v prefiero aplicar los cambios en la mig de v16.0 que opinas? |
|
@hugho-ad considero que son cambios seguros, desde que no estamos cambiando el comportamiento, sólo corrigiendo lints. En mi opinión, no necesitan pruebas. |
- Remove controllers/main.py, as the controller logic has been consolidated into reports/report_xls.py. - Update imports to reflect the new structure. - Modernize the codebase while maintaining backward compatibility for XLS report generation.
|
Hi @hugho-ad, I applied the comments of Luis G. Also, I deleted the controllers folder. Can you check this MR? Regards. |
hugho-ad
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.