Skip to content

length of AudioWorkletProcessor.process() parameter sequences with inactive inputs #1935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
karlt opened this issue May 31, 2019 · 4 comments · Fixed by #1957
Closed

length of AudioWorkletProcessor.process() parameter sequences with inactive inputs #1935

karlt opened this issue May 31, 2019 · 4 comments · Fixed by #1957
Assignees
@padenot
Milestone
Web Audio V1

Comments

@karlt
Copy link
Contributor

karlt commented May 31, 2019

https://webaudio.github.io/web-audio-api/#dom-audioworkletprocessor-process-inputs-outputs-parameters-inputs currently says

If no connections exist to the nth input of the node during the current render quantum, then the content of inputs[n] is an empty array, indicating that zero channels of input are available. This is the only circumstance under which the number of elements of inputs[n] can be zero."

I assume the intention is the following?

If there are no actively processing AudioNodes connected to the nth input of the AudioWorkletNode for the current render quantum [...]

Otherwise ended AudioScheduledSourceNodes would obstruct the optimization if not explicitly disconnected.
@rtoy
Copy link
Member

rtoy commented Jun 3, 2019

I think that's the intent.

@hoch
Copy link
Member

hoch commented Jun 13, 2019

So this is answered? Can we close the issue?

@karlt
Copy link
Contributor Author

karlt commented Jun 18, 2019

The spec text doesn't quite match the intent right now. I suspect it predates resolution of #1471.

This issue should remain open until the spec text is adjusted.

@padenot padenot self-assigned this Jun 25, 2019
@rtoy rtoy added this to the Web Audio V1 milestone Jun 25, 2019
@padenot
Copy link
Member

padenot commented Jun 25, 2019

I'll update the text with prose using the concepts introduced in #1471.

padenot added a commit to padenot/web-audio-api that referenced this issue Jun 26, 2019
@padenot
Update the length of the parameter sequence after WebAudio#1471.
dde81dc 
This fixes WebAudio#1935.
@padenot padenot mentioned this issue Jun 26, 2019
Merged
moz-v2v-gh pushed a commit to mozilla/gecko-dev that referenced this issue Jul 18, 2019
@karlt
bug 1558123 create JSObjects for inputs/outputs AudioWorkletProcessor…
4469044 
….process() parameters r=padenot,bzbarsky

Objects are retained for re-use so as to reduce garbage generation and other
performance benefits.  This is currently unspecified.

https://github.com/WebAudio/web-audio-api/issues/1934
WebAudio/web-audio-api#1933

WebAudio/web-audio-api#1935 tracks specification of
zero-channels of input when inputs are not actively processing.

Differential Revision: https://phabricator.services.mozilla.com/D34836

--HG--
extra : moz-landing-system : lando
lissyx pushed a commit to lissyx/mozilla-central that referenced this issue Jul 18, 2019
@karlt
bug 1558123 create JSObjects for inputs/outputs AudioWorkletProcessor…
02c650d 
….process() parameters r=padenot,bzbarsky

Objects are retained for re-use so as to reduce garbage generation and other
performance benefits.  This is currently unspecified.

https://github.com/WebAudio/web-audio-api/issues/1934
WebAudio/web-audio-api#1933

WebAudio/web-audio-api#1935 tracks specification of
zero-channels of input when inputs are not actively processing.

Differential Revision: https://phabricator.services.mozilla.com/D34836
gecko-dev-updater pushed a commit to marco-c/gecko-dev-comments-removed that referenced this issue Oct 4, 2019
@marco-c
bug 1558123 create JSObjects for inputs/outputs AudioWorkletProcessor…
9b7bb77 
….process() parameters r=padenot,bzbarsky

Objects are retained for re-use so as to reduce garbage generation and other
performance benefits.  This is currently unspecified.

https://github.com/WebAudio/web-audio-api/issues/1934
WebAudio/web-audio-api#1933

WebAudio/web-audio-api#1935 tracks specification of
zero-channels of input when inputs are not actively processing.

Differential Revision: https://phabricator.services.mozilla.com/D34836

UltraBlame original commit: 3cbbbf45fe77986a8fdeaa8d67fa95aded0427ab
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified that referenced this issue Oct 4, 2019
@marco-c
bug 1558123 create JSObjects for inputs/outputs AudioWorkletProcessor…
59d2a62 
….process() parameters r=padenot,bzbarsky

Objects are retained for re-use so as to reduce garbage generation and other
performance benefits.  This is currently unspecified.

https://github.com/WebAudio/web-audio-api/issues/1934
WebAudio/web-audio-api#1933

WebAudio/web-audio-api#1935 tracks specification of
zero-channels of input when inputs are not actively processing.

Differential Revision: https://phabricator.services.mozilla.com/D34836

UltraBlame original commit: 3cbbbf45fe77986a8fdeaa8d67fa95aded0427ab
gecko-dev-updater pushed a commit to marco-c/gecko-dev-wordified-and-comments-removed that referenced this issue Oct 4, 2019
@marco-c
bug 1558123 create JSObjects for inputs/outputs AudioWorkletProcessor…
cee3245 
….process() parameters r=padenot,bzbarsky

Objects are retained for re-use so as to reduce garbage generation and other
performance benefits.  This is currently unspecified.

https://github.com/WebAudio/web-audio-api/issues/1934
WebAudio/web-audio-api#1933

WebAudio/web-audio-api#1935 tracks specification of
zero-channels of input when inputs are not actively processing.

Differential Revision: https://phabricator.services.mozilla.com/D34836

UltraBlame original commit: 3cbbbf45fe77986a8fdeaa8d67fa95aded0427ab
@padenot padenot mentioned this issue Mar 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@padenot padenot

Labels
None yet
Projects
None yet
Milestone
Web Audio V1
Development

Successfully merging a pull request may close this issue.

Update the length of the parameter sequence after #1471. padenot/web-audio-api
4 participants
@padenot @rtoy @hoch @karlt