Skip to content

Update the length of the parameter sequence after #1471. #1957

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 28, 2019
Merged

Update the length of the parameter sequence after #1471. #1957

merged 2 commits into from
Jun 28, 2019

Conversation

padenot
Copy link
Member

@padenot padenot commented Jun 26, 2019 •
edited by pr-preview bot
Loading

This fixes #1935.

Preview | Diff

@padenot padenot requested a review from hoch June 26, 2019 20:10
@padenot padenot self-assigned this Jun 26, 2019
@padenot padenot added this to the Web Audio V1 milestone Jun 26, 2019
hoch
hoch approved these changes Jun 27, 2019
View reviewed changes
Copy link
Member

@hoch hoch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a nit

@padenot padenot merged commit 35e55e5 into WebAudio:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoch hoch hoch approved these changes

Assignees

@padenot padenot

Labels
None yet
Projects
None yet
Milestone
Web Audio V1
Development

Successfully merging this pull request may close these issues.

length of AudioWorkletProcessor.process() parameter sequences with inactive inputs
2 participants
@padenot @hoch