Extract survey results logic into separate SurveyResultsController#6367
Merged
ragesoss merged 1 commit intoJun 20, 2025
Conversation
Abishekcs
force-pushed
the
refactor/survey-results-to-new-controller
branch
from
014eb0e to
dde7603
Compare
Abishekcs
changed the title
ragesoss
reviewed
Jun 18, 2025
Contributor
Author
|
@ragesoss I’ve made the required changes. Could you please review this PR whenever you have a time? Thank you! |
ragesoss
reviewed
Jun 19, 2025
ragesoss
reviewed
Jun 19, 2025
Abishekcs
force-pushed
the
refactor/survey-results-to-new-controller
branch
from
c9a5b82 to
d1f0c1b
Compare
Contributor
Author
|
Hi @ragesoss, I've made the required changes and tried to keep them as minimal as possible. Please let me know if any further adjustments are needed. Thanks again for your helpful review! |
Contributor
Author
|
I don't think the failing test are related to the changes made in this PR. Test seems to pass locally
|
Member
|
Looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
This PR introduces a refactor that moves the
resultsaction fromSurveysControllerinto a newSurveyResultsController. The goal is to isolate logic related to survey results, reducing complexity in the main controller and setting the stage for further enhancements (performance improvements #6329).Screenshots
Before:
Before.mp4
After:
2025-06-18.17-00-00.mp4