Skip to content

CPLAT-6014 Fix Dart2 RTE #299

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 11, 2019
Merged

CPLAT-6014 Fix Dart2 RTE #299

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6900490
Fix Dart 2 RTE
aaronlademann-wf Jun 5, 2019
915cce5
Update .gitignore
aaronlademann-wf Jun 5, 2019
571ae11
Merge branch 'master' of github.com:Workiva/dart_dev into fix-dart2-rte
bender-wk Jun 11, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
.packages
.pub
.dart_tool
packages
pubspec.lock
build/
Expand Down
2 changes: 1 addition & 1 deletion lib/src/task_process.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ class TaskProcess {
pids = pids ?? [_process.pid];
String executable = 'pgrep';
List<TaskProcess> pgreps = [];
var args = [];
List<String> args = [];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fyi the other option here would be var/final args = <String>[];

List<int> cpids = [];
for (int pid in pids) {
args = [];
Expand Down