CPLAT-3974 Remove workaround for DDC bug that is fixed in Dart 2 #229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
corwinsheahan-wf
approved these changes
Feb 5, 2019
|
We need to be sure that this only gets included in the 2.x.x+dart2 release. Dart 1 users will still need this workaround. |
|
@corwin Yup, once 2.0.0-dev is merged into master, master will be considered dart2-only and all dart1 releases and fixes will be based off of a |
evanweible-wf
added
the
dart2
|
+10 |
|
@Workiva/release-management-pp |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
There was an emulated function name bug in the Dart Dev Compiler (dart-lang/sdk#27647) that has since been fixed. Our dart2-specific branch of this library no longer needs the workaround for this bug.
How it was fixed:
Remove the workaround and related code/tests.
Testing suggestions:
Potential areas of regression:
n/a